8381316: HttpClient / Http3: poor exception messages on SSL handshake errors

[djelinski]

This PR improves the exceptions thrown from HttpClient.send when the QUIC TLS handshake fails on the client side, for example because the server certificate is not trusted.

Before the changes we would throw the following exception chain:

javax.net.ssl.SSLHandshakeException: QUIC connection establishment failed
Caused by: javax.net.ssl.SSLHandshakeException: QUIC connection establishment failed
Caused by: java.io.IOException: certificate_unknown

After the changes the following exception chain is thrown:

javax.net.ssl.SSLHandshakeException: (certificate_unknown) PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
Caused by: javax.net.ssl.SSLHandshakeException: (certificate_unknown) PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
Caused by: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
Caused by: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

The new exception chain matches the one observed with HTTP 1/2.

I updated a preexisting test to cover HTTP3, and added assertions to verify the exception message. HttpClient tests continue to pass.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8381316: HttpClient / Http3: poor exception messages on SSL handshake errors (Bug - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30563/head:pull/30563
$ git checkout pull/30563

Update a local copy of the PR:
$ git checkout pull/30563
$ git pull https://git.openjdk.org/jdk.git pull/30563/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30563

View PR using the GUI difftool:
$ git pr show -t 30563

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30563.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8381316: HttpClient / Http3: poor exception messages on SSL handshake errors

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 92 new commits pushed to the master branch:

• f8ca6f6: 8381554: RISC-V: Small refactoring for cmp_klass_compressed macro-assembler routine
• 4bb7204: 8377181: HttpClient may leak closed QUIC connection objects
• 4253db2: 8350208: CTW: GraphKit::add_safepoint_edges asserts "not enough operands for reexecution"
• ... and 89 more: https://git.openjdk.org/jdk/compare/28e96d76b0c7a792cc88bb9183e9cb6a83fcaba2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@djelinski The following labels will be automatically applied to this pull request:

• net
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1df3a339)
• 00: Full (c907be81)

[djelinski]

Thanks @dfuch for the review. Changes applied.