8381596: Adjust checks which use supports_ht() on x86 for hybrid CPUs

[vnkozlov]

There are several checks in vm_version_x86.cpp which uses supports_ht() which are used to set some flags:

Unfortunately HT is not supported on efficient cores in hybrid Intel CPU but supported on performance cores. We find it by comparing recorded CPU features in AOT cache and compare it during production run (AOT code was rejected when mismatched).

I added supports_hybrid() and supports_avx() to such checks so that flags setting will be consistent.

Tested tier1-3, comp-stress

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8381596: Adjust checks which use supports_ht() on x86 for hybrid CPUs (Bug - P4)

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Igor Veresov (@veresov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30557/head:pull/30557
$ git checkout pull/30557

Update a local copy of the PR:
$ git checkout pull/30557
$ git pull https://git.openjdk.org/jdk.git pull/30557/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30557

View PR using the GUI difftool:
$ git pr show -t 30557

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30557.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8381596: Adjust checks which use supports_ht() on x86 for hybrid CPUs

Reviewed-by: iklam, iveresov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 4a47011: 8369699: Template Framework Library: add VectorAPI types and operations
• f8ca6f6: 8381554: RISC-V: Small refactoring for cmp_klass_compressed macro-assembler routine
• 4bb7204: 8377181: HttpClient may leak closed QUIC connection objects
• ... and 5 more: https://git.openjdk.org/jdk/compare/5e89669d180a4ac969f13cf6c066efbdb9998dc5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vnkozlov The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (34033e63)

[vnkozlov]

@iklam and @ashu-mehra please look.

[iklam]

LGTM

[vnkozlov]

Thank you, @iklam and @veresov, for review.

[vnkozlov]

/integrate

[openjdk]

Going to push as commit ba0aefb.
Since your change was applied there have been 8 commits pushed to the master branch:

• 4a47011: 8369699: Template Framework Library: add VectorAPI types and operations
• f8ca6f6: 8381554: RISC-V: Small refactoring for cmp_klass_compressed macro-assembler routine
• 4bb7204: 8377181: HttpClient may leak closed QUIC connection objects
• ... and 5 more: https://git.openjdk.org/jdk/compare/5e89669d180a4ac969f13cf6c066efbdb9998dc5...master

Your commit was automatically rebased without conflicts.

[iwanowww]

Looks good.

[iwanowww]

It's an interesting criteria to classify Intel CPUs :-)

On a more serious note, the code would benefit from some cleanup. Seeing "newest" and "modern" used for SSE4.2 and AVX-capable CPUs looks weird.

[vnkozlov]

Thank you, @iwanowww, for looking on this.
Apology for pushing before your review.

I share your view about wording which describes cpus configurations. May be we should file "starter" RFE to do such cleanup.

[dholmes-ora]

The VM_Version API for Intel CPUs needs a complete redesign around functional capabilities not descriptive ones (e.g. is_P6, is_modern, is_server, etc.). But it is definitely not a "starter" issue.

[openjdk]

@vnkozlov Pushed as commit ba0aefb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.