Skip to content

8376610: Test javax/net/ssl/TLS/TestJSSEClientDefaultProtocol.java then completed#30538

Open
myankelev wants to merge 1 commit intoopenjdk:masterfrom
myankelev:JDK-8376610
Open

8376610: Test javax/net/ssl/TLS/TestJSSEClientDefaultProtocol.java then completed#30538
myankelev wants to merge 1 commit intoopenjdk:masterfrom
myankelev:JDK-8376610

Conversation

@myankelev
Copy link
Copy Markdown
Member

@myankelev myankelev commented Apr 1, 2026

Introduced a countdown latch to prevent intermittent failure


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8376610: Test javax/net/ssl/TLS/TestJSSEClientDefaultProtocol.java then completed (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30538/head:pull/30538
$ git checkout pull/30538

Update a local copy of the PR:
$ git checkout pull/30538
$ git pull https://git.openjdk.org/jdk.git pull/30538/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30538

View PR using the GUI difftool:
$ git pr show -t 30538

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30538.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 1, 2026

👋 Welcome back myankelevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8376610: Test javax/net/ssl/TLS/TestJSSEClientDefaultProtocol.java then completed 8376610: Test javax/net/ssl/TLS/TestJSSEClientDefaultProtocol.java then completed Apr 1, 2026
@openjdk openjdk bot added the security security-dev@openjdk.org label Apr 1, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

@myankelev The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 1, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 1, 2026

Webrevs

@@ -89,9 +89,13 @@ public static CipherTestUtils.Server server(String protocol,
System.out.println("Testing protocol: " + protocol);
System.out.println("Testing cipher : " + cipher);

return CipherTestUtils.mainServer(
var server = CipherTestUtils.mainServer(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var server = CipherTestUtils.mainServer(
var server = CipherTestUtils.mainServer(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants