Skip to content

8379629: Add StressDeepIGVNRevisit diagnostic flag to force deep revisit in all IGVN optimize() calls#30535

Open
krk wants to merge 3 commits intoopenjdk:masterfrom
krk:stress-deep
Open

8379629: Add StressDeepIGVNRevisit diagnostic flag to force deep revisit in all IGVN optimize() calls#30535
krk wants to merge 3 commits intoopenjdk:masterfrom
krk:stress-deep

Conversation

@krk
Copy link
Copy Markdown

@krk krk commented Apr 1, 2026

Add StressDeepIGVNRevisit diagnostic flag (all/random) to force deep revisit in PhaseIterGVN::optimize() calls, helping uncover latent optimizer bugs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8379629: Add StressDeepIGVNRevisit diagnostic flag to force deep revisit in all IGVN optimize() calls (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30535/head:pull/30535
$ git checkout pull/30535

Update a local copy of the PR:
$ git checkout pull/30535
$ git pull https://git.openjdk.org/jdk.git pull/30535/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30535

View PR using the GUI difftool:
$ git pr show -t 30535

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30535.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 1, 2026

👋 Welcome back krk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Apr 1, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

@krk The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 1, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 1, 2026

Webrevs

@robcasloz
Copy link
Copy Markdown
Contributor

/cc hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 2, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 2, 2026

@robcasloz
The hotspot-compiler label was successfully added.

"Re-process nodes that could benefit from a deep revisit after " \
"the IGVN worklist drains") \
\
product(ccstr, StressDeepIGVNRevisit, nullptr, DIAGNOSTIC, \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see all the product DIAGNOSTIC stress flags at the beginning of the file. I'm unsure if that's by design to facilitate discovery or if in your case it's fine to keep it below the UseDeepIGVNRevisit. Maybe someone else can shed a light on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants