8379629: Add StressDeepIGVNRevisit diagnostic flag to force deep revisit in all IGVN optimize() calls#30535
Open
krk wants to merge 3 commits intoopenjdk:masterfrom
Open
8379629: Add StressDeepIGVNRevisit diagnostic flag to force deep revisit in all IGVN optimize() calls#30535krk wants to merge 3 commits intoopenjdk:masterfrom
krk wants to merge 3 commits intoopenjdk:masterfrom
Conversation
…sit in all IGVN optimize() calls
|
👋 Welcome back krk! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Webrevs
|
Contributor
|
/cc hotspot-compiler |
|
@robcasloz |
anton-seoane
reviewed
Apr 2, 2026
| "Re-process nodes that could benefit from a deep revisit after " \ | ||
| "the IGVN worklist drains") \ | ||
| \ | ||
| product(ccstr, StressDeepIGVNRevisit, nullptr, DIAGNOSTIC, \ |
Contributor
There was a problem hiding this comment.
I see all the product DIAGNOSTIC stress flags at the beginning of the file. I'm unsure if that's by design to facilitate discovery or if in your case it's fine to keep it below the UseDeepIGVNRevisit. Maybe someone else can shed a light on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
StressDeepIGVNRevisitdiagnostic flag (all/random) to force deep revisit inPhaseIterGVN::optimize()calls, helping uncover latent optimizer bugs.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30535/head:pull/30535$ git checkout pull/30535Update a local copy of the PR:
$ git checkout pull/30535$ git pull https://git.openjdk.org/jdk.git pull/30535/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30535View PR using the GUI difftool:
$ git pr show -t 30535Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30535.diff
Using Webrev
Link to Webrev Comment