Skip to content

8361403: [VectorAPI] Missing Identity transforms for vector MUL, ADD, SUB operations#30532

Open
jatin-bhateja wants to merge 1 commit intoopenjdk:masterfrom
jatin-bhateja:JDK-8361403
Open

8361403: [VectorAPI] Missing Identity transforms for vector MUL, ADD, SUB operations#30532
jatin-bhateja wants to merge 1 commit intoopenjdk:masterfrom
jatin-bhateja:JDK-8361403

Conversation

@jatin-bhateja
Copy link
Copy Markdown
Member

@jatin-bhateja jatin-bhateja commented Apr 1, 2026

Patch adds following identity and ideal transformation for vector MUL, ADD and SUB node generated through vector API flow.

  • X + 0 => X
  • X * 1 => X
  • X – 0 => X
  • X – X => 0
  • X * 0 => 0

Also included an extensive IR verification test with both predicated and non-predicated vector operation test points.

Kindly review and share your feedback.

Best Regards,
Jatin


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361403: [VectorAPI] Missing Identity transforms for vector MUL, ADD, SUB operations (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30532/head:pull/30532
$ git checkout pull/30532

Update a local copy of the PR:
$ git checkout pull/30532
$ git pull https://git.openjdk.org/jdk.git pull/30532/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30532

View PR using the GUI difftool:
$ git pr show -t 30532

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30532.diff

Using Webrev

Link to Webrev Comment

@jatin-bhateja
Copy link
Copy Markdown
Member Author

/label add hotspot-compiler-dev

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 1, 2026

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 1, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

@jatin-bhateja
The hotspot-compiler label was successfully added.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

@jatin-bhateja To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@jatin-bhateja jatin-bhateja marked this pull request as ready for review April 2, 2026 08:47
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 2, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 2, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant