-
Couldn't load subscription status.
- Fork 6.1k
8369346: Remove default value of and deprecate the MaxRAM flag #27952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8369346: Remove default value of and deprecate the MaxRAM flag #27952
Conversation
|
👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into |
|
@jsikstro This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/label remove graal |
|
@jsikstro |
|
@jsikstro |
Webrevs
|
Hello,
Please see the CSR for a more detailed explanation and specific information regarding the deprecation of the flag. To summarize, the JVM is well-equiped to detect system memory and handle potential truncation errors (see JDK-8367413 ), making MaxRAM largely redundant. Removing the default value from MaxRAM mainly impacts systems with more memory than the default (128GB on 64-bit systems and 4GB on 32-bit systems) that are running with
-XX:-UseCompressedOopsor-XX:+UseZGC, which disable compressed oops. We recommend users to use well-supported flags such as-Xmsand-Xmxto influence heap sizing instead.MaxRAM is used to a very small extent to influence memory allocation in JDK tests, where MaxRAMPercentage is much more common. When MaxRAM is eventually obsoleted, the few affected tests will need to be updated or use alternative flags.
Testing:
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27952/head:pull/27952$ git checkout pull/27952Update a local copy of the PR:
$ git checkout pull/27952$ git pull https://git.openjdk.org/jdk.git pull/27952/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27952View PR using the GUI difftool:
$ git pr show -t 27952Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27952.diff
Using Webrev
Link to Webrev Comment