-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8370065: Windows perfmemory coding - use SetSecurityDescriptorControl directly #27937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
|
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
|
Thanks for the reviews ! /integrate |
|
Going to push as commit b597b65.
Your commit was automatically rebased without conflicts. |
We have some 'at runtime' checks for availability of SetSecurityDescriptorControl in the Windows perfmemory coding. But those were done for very old Windows versions like Win98 and can probably be removed.
Looking at the description
https://learn.microsoft.com/en-us/windows/win32/api/securitybaseapi/nf-securitybaseapi-setsecuritydescriptorcontrol
it is available at least since Win2003/XP so the function can be called directly.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27937/head:pull/27937$ git checkout pull/27937Update a local copy of the PR:
$ git checkout pull/27937$ git pull https://git.openjdk.org/jdk.git pull/27937/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27937View PR using the GUI difftool:
$ git pr show -t 27937Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27937.diff
Using Webrev
Link to Webrev Comment