8365896: Remove unnecessary explicit buffer nul-termination after using os::snprintf

[Arraying]

Hi all,

This PR removes some leftover null terminators and buffer reservations for null terminators, which have been made redundant with the new snprintf family of functions.

In order to find these occurrences, I methodologically used multiple regular expressions over the entire codebase. I took a look at around 130 files in total, and updated where appropriate.

I’ve tested this through tiers 1-5 on Linux (x64, AArch64), macOS (x64, AArch64) and Windows (x64). I’ve also successfully compiled for PowerPC and Zero on Linux.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365896: Remove unnecessary explicit buffer nul-termination after using os::snprintf (Enhancement - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27920/head:pull/27920
$ git checkout pull/27920

Update a local copy of the PR:
$ git checkout pull/27920
$ git pull https://git.openjdk.org/jdk.git pull/27920/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27920

View PR using the GUI difftool:
$ git pr show -t 27920

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27920.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back phubner! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Arraying This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365896: Remove unnecessary explicit buffer nul-termination after using os::snprintf

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

• 94c0611: 8370122: jpackage test lib improvements
• ed153ee: 8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data
• cac2519: 8356578: Test --mac-entitlements
• ... and 36 more: https://git.openjdk.org/jdk/compare/5609ee11a2daf888d02c0c1b2b70eb4df817582c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@Arraying The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (18bcd59f)

[dholmes-ora]

They all seem fine to me. Thanks for doing this cleanup.