8364929: Assign unique id to each AdapterBlob stored in AOTCodeCache #27553
+29
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch assigns unique id to each AdapterHandlerEntry so as to avoid using hash computed from AdapterFingerPrint which may not be unique. Unique id allows AOTCodeCache to locate the AdapterBlob being requested to be loaded.
Testing:
Before this patch
runtime/cds/appcds/aotClassLinking/StringConcatStress.java
emits warning messages in the production run:With this patch, such warnings are not seen at all
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27553/head:pull/27553
$ git checkout pull/27553
Update a local copy of the PR:
$ git checkout pull/27553
$ git pull https://git.openjdk.org/jdk.git pull/27553/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27553
View PR using the GUI difftool:
$ git pr show -t 27553
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27553.diff
Using Webrev
Link to Webrev Comment