8368882: NPE during text drawing on machine with JP locale #27551
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a reproducible bug in symbol rendering on Windows machines with particular default locales. This changeset fixes the deferred font initialisation request, which now skips the last font in the list.
The test (attached to the jira) was performed on a Windows 11 machine with the Japanese locale set as the default. Without the fix, it fails with an NPE. With the fix it displays a window showing glyphs drawn by all the fonts accessible from the Java application.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27551/head:pull/27551
$ git checkout pull/27551
Update a local copy of the PR:
$ git checkout pull/27551
$ git pull https://git.openjdk.org/jdk.git pull/27551/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27551
View PR using the GUI difftool:
$ git pr show -t 27551
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27551.diff
Using Webrev
Link to Webrev Comment