Skip to content

Conversation

snazarkin
Copy link
Contributor

@snazarkin snazarkin commented Sep 29, 2025

There is a reproducible bug in symbol rendering on Windows machines with particular default locales. This changeset fixes the deferred font initialisation request, which now skips the last font in the list.

The test (attached to the jira) was performed on a Windows 11 machine with the Japanese locale set as the default. Without the fix, it fails with an NPE. With the fix it displays a window showing glyphs drawn by all the fonts accessible from the Java application.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368882: NPE during text drawing on machine with JP locale (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27551/head:pull/27551
$ git checkout pull/27551

Update a local copy of the PR:
$ git checkout pull/27551
$ git pull https://git.openjdk.org/jdk.git pull/27551/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27551

View PR using the GUI difftool:
$ git pr show -t 27551

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27551.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2025

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 29, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 29, 2025

@snazarkin The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 29, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant