Skip to content

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Sep 27, 2025

See issue description and discussion. We set the thread name at the OS level, but only for ASAN builds, since outside of that narrow use case we consider attached threads to be owned by the application, not us, so we don't interfere with it.

Tested manually with an ASAN build and a custom java launcher that attaches some native threads.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368621: In ASAN builds, attached non-main threads should have meaningful native names (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27535/head:pull/27535
$ git checkout pull/27535

Update a local copy of the PR:
$ git checkout pull/27535
$ git pull https://git.openjdk.org/jdk.git pull/27535/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27535

View PR using the GUI difftool:
$ git pr show -t 27535

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27535.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2025

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8368621: In ASAN builds, attached non-main threads should have meaningful native names 8368621: In ASAN builds, attached non-main threads should have meaningful native names Sep 27, 2025
@openjdk
Copy link

openjdk bot commented Sep 27, 2025

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@tstuefe tstuefe marked this pull request as ready for review September 27, 2025 11:56
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 27, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2025

Webrevs

@tstuefe tstuefe marked this pull request as draft September 28, 2025 18:53
@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant