8361614: Missing sub-int value validation in the Class-File API

[liach]

In the class file format, a lot of the values are u1 or u2; the Class-File API consistently model them with int. However, the API does not, in general, validate that int values passed to the factory methods are not out of the bounds as defined in the class file format. This patch proposes to add such validation for factory methods accepting such more narrow data, prepared by examining all int-accepting methods in the Class-File API.

I expect this to have a small compatibility impact - besides the -1 for the minor version, there is no other places where most significant bits are ever meaningful, and I special cased it and consistently fail fast for all other OOB values, which always mean programmer errors.

A CSR will be created soon as well.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires CSR request JDK-8361637 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8361614: Missing sub-int value validation in the Class-File API (Bug - P4)
• JDK-8361637: Missing sub-int value validation in the Class-File API (CSR)

Reviewers

• Adam Sotona (@asotona - Reviewer) 🔄 Re-review required (review applies to 67aa74ae)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26201/head:pull/26201
$ git checkout pull/26201

Update a local copy of the PR:
$ git checkout pull/26201
$ git pull https://git.openjdk.org/jdk.git pull/26201/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26201

View PR using the GUI difftool:
$ git pr show -t 26201

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26201.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full (96f50b0f)
• 01: Full - Incremental (67aa74ae)
• 00: Full (74fd977d)

[asotona]

Nice summary fix of the validation.