8357089: Remove VFORK launch mechanism from Process implementation (linux) #25768
Conversation
|
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
tstuefe
force-pushed
the
JDK-8357089-Remove-VFORK-launch-mechanism-from-Process-implementation-linux-
branch
from
fc35c34 to
f94fd12
Compare
|
/reviewers 2 reviewers |
| * the libc in terms of one of (fork|vfork|clone)+exec - so whether or not it | ||
| * has advantages over calling the naked (fork|vfork|clone) functions depends | ||
| * on how posix_spawn(3) is implemented. | ||
| * D) posix_spawn(3): Where fork/vfork/clone all fork off the process and leave |
There was a problem hiding this comment.
I would downplay the OS launch options we don't use, only saying that vfork is dangerous (and a bit as to why) but there's no need to mention clone. And there's no need to mention the the deprecation or removal, when this is integrated its gone.
| @@ -57,7 +57,7 @@ | |||
| * changing paths... | |||
| * - then exec(2) the target binary | |||
| * | |||
| * There are three ways to fork off: | |||
| * On the OS-side are four ways to fork off: | |||
There was a problem hiding this comment.
I would mention the two ways that are implemented, only mentioning vfork after the supported mechanisms to inhibit someone wanting to go backwards.
| @@ -205,31 +205,6 @@ initVectorFromBlock(const char**vector, const char* block, int count) | |||
| vector[count] = NULL; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This mode should be mentioned in the CSR, even if no-one knew it was there.
|
@RogerRiggs |
|
@tstuefe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
(for JDK 26)
Note: This PR is a continuation of the old PR here: #25260; had to close the old one since I had Skara problems after the JDK25 split-off.
See the companion CSR (https://bugs.openjdk.org/browse/JDK-8357090) for the ratio behind this removal.
Patch
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25768/head:pull/25768$ git checkout pull/25768Update a local copy of the PR:
$ git checkout pull/25768$ git pull https://git.openjdk.org/jdk.git pull/25768/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25768View PR using the GUI difftool:
$ git pr show -t 25768Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25768.diff
Using Webrev
Link to Webrev Comment