8359024: Accessibility bugs in API documentation #25716
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review a change to fix a couple of accessibility errors in JDK API documentation as detected by our accessibility testing.
Contrast between link and normal text colors was below 3 and therefore would have required other styling (such as underlining). This is fixed by slightly darkening text color (our text color isn't black but dark-gray).
Old colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=282828&bcolor=FFFFFF&lcolor=437291
New colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=FFFFFF&lcolor=437291
Links in the headings of inherited member summaries used the wrong color and contrast to background color was below 4.5. This is fixed by removing a bogus
.expanded
selector that shouldn't have been there in the first place.Old colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=DEE3E9&lcolor=437291
New colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=DEE3E9&lcolor=47688A
Remove the
role="tablist"
andaria-orientation="horizontal"
attributes from table captions if they do not contain tabs. This is the only code change, and the only change that comes with a test change (I guess the CSS changes arenoreg-hard
as we don't have a way to do automatic accessibility testing).All changes are invisible or so subtle that they are practically impossible to spot in normal browsing, so I spare myself the task of uploading demo docs.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25716/head:pull/25716
$ git checkout pull/25716
Update a local copy of the PR:
$ git checkout pull/25716
$ git pull https://git.openjdk.org/jdk.git pull/25716/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25716
View PR using the GUI difftool:
$ git pr show -t 25716
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25716.diff
Using Webrev
Link to Webrev Comment