8353232: Standardizing and Unifying XML Component Configurations

[JoeWang-Java]

This is a refactor patch, no change in functionality.

This patch refactor the configuration code. Rather than for each factory to go through the whole configuration process, a base configuration as represented in JdkXmlConfig is created once, which includes loading of the JAXP Configuration file, factories then get their own copies of the property managers, created on top of the base ones rather than directly constructed.

The JDKCatalog and its Resolver are lazily initialized when external references are encountered. This code replaces the original code block within the security manager. This change also addresses JDK-8350189.

The rest of changes basically replace all direct constructions of XMLSecurityManager/XMLSecurityPropertyManager with calls to JdkXmlConfig's corresponding get methods, which return clones of the base instances. in the factory classes, these clones are updated with property settings on the factories. In non-public or legacy code paths (inherited from upstream components), such updates may not be necessary.

Tests: existing tests T1-3 passed; XML JCK tests passed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353232: Standardizing and Unifying XML Component Configurations (Enhancement - P4)

Reviewers

• Lance Andersen (@LanceAndersen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25102/head:pull/25102
$ git checkout pull/25102

Update a local copy of the PR:
$ git checkout pull/25102
$ git pull https://git.openjdk.org/jdk.git pull/25102/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25102

View PR using the GUI difftool:
$ git pr show -t 25102

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25102.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353232: Standardizing and Unifying XML Component Configurations

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 8c1b915: 8356126: Duplication handling and optimization of CaptureCallState
• 3f6b177: 8332934: Do loop with continue with subsequent switch leads to incorrect stack maps
• cb02158: 8354461: Update tests to disable streaming output for attach tools
• ... and 3 more: https://git.openjdk.org/jdk/compare/c8a30c2aaba04c11b70a4f74ee74452250be6e59...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@JoeWang-Java The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7289d2a8)

[LanceAndersen]

Hi Joe,

This looks good overall.