8351232: NPE: Cannot invoke "getDeclarationAttributes" because "sym" is null

[asotona]

Javac throws NPE in very specific circumstances described in JDK-8351232.
The NPE has been fixed as a side effect of "stripMetadata" call in the recent JDK-8355065 fix.

This PR only adds a test case to avoid regression of the NPE.

Please review.

Thank you,
Adam

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8351232: NPE: Cannot invoke "getDeclarationAttributes" because "sym" is null (Bug - P3)

Reviewers

• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25098/head:pull/25098
$ git checkout pull/25098

Update a local copy of the PR:
$ git checkout pull/25098
$ git pull https://git.openjdk.org/jdk.git pull/25098/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25098

View PR using the GUI difftool:
$ git pr show -t 25098

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25098.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351232: NPE: Cannot invoke "getDeclarationAttributes" because "sym" is null

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 90f0f1b: 8354443: [Graal] crash after deopt in TestG1BarrierGeneration.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@asotona The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (67c36535)

[liach]

Looks reasonable to me

[asotona]

Thanks for the review!
/integrate

[openjdk]

Going to push as commit 1d36f17.
Since your change was applied there have been 148 commits pushed to the master branch:

• 883e52a: 8353237: [AArch64] Incorrect result of VectorizedHashCode intrinsic on Cortex-A53
• 13b3541: 8356866: Cleanup hotspot/jtreg/ProblemList.txt
• b8d2bdb: 8355743: G1: Collection set clearing is not recorded as part of "Free Collection Set Time"
• ... and 145 more: https://git.openjdk.org/jdk/compare/d7e648bb2737362d3cba3350cae63b1013967a66...master

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona Pushed as commit 1d36f17.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.