Skip to content

7046003: Default value of Authenticator.getRequestingURL() is not specified #25097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kieran-farrell
Copy link

@kieran-farrell kieran-farrell commented May 7, 2025

Clarificatiion of spec to outline that Authenticator.getRequestingURL() returns null in the event that the corresponding request does not specify a URL.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8356410 to be approved

Issues

  • JDK-7046003: Default value of Authenticator.getRequestingURL() is not specified (Bug - P4)
  • JDK-8356410: Default value of Authenticator.getRequestingURL() is not specified (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25097/head:pull/25097
$ git checkout pull/25097

Update a local copy of the PR:
$ git checkout pull/25097
$ git pull https://git.openjdk.org/jdk.git pull/25097/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25097

View PR using the GUI difftool:
$ git pr show -t 25097

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25097.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2025

👋 Welcome back kieran-farrell! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 7, 2025
@openjdk
Copy link

openjdk bot commented May 7, 2025

@kieran-farrell The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented May 7, 2025

Webrevs

@liach
Copy link
Member

liach commented May 7, 2025

/csr needed

Need a small CSR to record this API specification update. You can create the CSR after the text has settled down.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label May 7, 2025
@openjdk
Copy link

openjdk bot commented May 7, 2025

@liach has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@kieran-farrell please create a CSR request for issue JDK-7046003 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@kieran-farrell
Copy link
Author

/csr needed

Need a small CSR to record this API specification update. You can create the CSR after the text has settled down.

@liach I populated the previously created CSR CCC-7046003 as linked to the bug.

Would you be okay to review?

@liach
Copy link
Member

liach commented May 7, 2025

CCC is a legacy internal process only present for archival purposes. I think we should withdraw that CCC and remove the "csr of" link so we can create a new CSR.

@kieran-farrell
Copy link
Author

CCC is a legacy internal process only present for archival purposes. I think we should withdraw that CCC and remove the "csr of" link so we can create a new CSR.

@liach - Old CSR withdrawn and new CSR created - JDK-8356410, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csr Pull request needs approved CSR before integration net [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants