-
Notifications
You must be signed in to change notification settings - Fork 5.8k
7046003: Default value of Authenticator.getRequestingURL() is not specified #25097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back kieran-farrell! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@kieran-farrell The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
/csr needed Need a small CSR to record this API specification update. You can create the CSR after the text has settled down. |
@liach has indicated that a compatibility and specification (CSR) request is needed for this pull request. @kieran-farrell please create a CSR request for issue JDK-7046003 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
@liach I populated the previously created CSR CCC-7046003 as linked to the bug. Would you be okay to review? |
CCC is a legacy internal process only present for archival purposes. I think we should withdraw that CCC and remove the "csr of" link so we can create a new CSR. |
@liach - Old CSR withdrawn and new CSR created - JDK-8356410, thank you |
Clarificatiion of spec to outline that Authenticator.getRequestingURL() returns null in the event that the corresponding request does not specify a URL.
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25097/head:pull/25097
$ git checkout pull/25097
Update a local copy of the PR:
$ git checkout pull/25097
$ git pull https://git.openjdk.org/jdk.git pull/25097/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25097
View PR using the GUI difftool:
$ git pr show -t 25097
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25097.diff
Using Webrev
Link to Webrev Comment