8356395: Spec needs to be clarified for InterfaceAddress class level API documentation and getBroadcast() method

[kieran-farrell]

Spec currently suggests that only IPv6 addresses can return null for InterfaceAddress.getBroadcast(). Clarifying spec to state that certain IPv4 address such as the loopback address do not support broadcasting and can therefore also return null.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8356002 to be approved

Issues

• JDK-8356395: Spec needs to be clarified for InterfaceAddress class level API documentation and getBroadcast() method (Bug - P4)
• JDK-8356002: Spec needs to be clarified for InterfaceAddress class level API documentation and getBroadcast() method (CSR)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25095/head:pull/25095
$ git checkout pull/25095

Update a local copy of the PR:
$ git checkout pull/25095
$ git pull https://git.openjdk.org/jdk.git pull/25095/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25095

View PR using the GUI difftool:
$ git pr show -t 25095

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25095.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kieran-farrell! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kieran-farrell This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356395: Spec needs to be clarified for InterfaceAddress class level API documentation and getBroadcast() method

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 255 new commits pushed to the master branch:

• 5e50a58: 8356838: AOT incorrectly sets a cached class's loader type to boot
• b66ab8e: 8356693: AOT assembly phase fails with -javaagent
• 948ade8: 8356971: [JVMCI] Export VM_Version::supports_avx512_simd_sort to JVMCI compiler
• ... and 252 more: https://git.openjdk.org/jdk/compare/1313349a2efd42ab84a543dfee11e3547f6ef4a3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@kieran-farrell The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (83beab73)
• 01: Full - Incremental (c3915e21)
• 00: Full (f6bc4122)

[dfuch]

/csr needed

[openjdk]

@dfuch has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@kieran-farrell please create a CSR request for issue JDK-8356395 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[dfuch]

I like this new version.

[kieran-farrell]

/integrate

[openjdk]

@kieran-farrell
Your change (at version 83beab7) is now ready to be sponsored by a Committer.

[dfuch]

/sponsor

[openjdk]

Going to push as commit a8d8ffa.
Since your change was applied there have been 276 commits pushed to the master branch:

• f6b0f01: 8332947: [macos] OpenURIHandler events not received when AWT is embedded in another toolkit
• efdbb6a: 8354083: Support --add-reads with -XX:+AOTClassLinking
• fe790cb: 8356177: Regression after JDK-8352180
• ... and 273 more: https://git.openjdk.org/jdk/compare/1313349a2efd42ab84a543dfee11e3547f6ef4a3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch @kieran-farrell Pushed as commit a8d8ffa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.