Skip to content

8356390: Rename ResolvedIndyEntry::set_flags to set_has_appendix #25092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdksjolen
Copy link
Contributor

@jdksjolen jdksjolen commented May 7, 2025

The set_flags function really only sets whether it has an appendix or not, and there's a separate set_resolution_failed method just below that also alters the flag. Just rename this to set_has_appendix


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356390: Rename ResolvedIndyEntry::set_flags to set_has_appendix (Enhancement - P4)

Contributors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25092/head:pull/25092
$ git checkout pull/25092

Update a local copy of the PR:
$ git checkout pull/25092
$ git pull https://git.openjdk.org/jdk.git pull/25092/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25092

View PR using the GUI difftool:
$ git pr show -t 25092

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25092.diff

Using Webrev

Link to Webrev Comment

@jdksjolen
Copy link
Contributor Author

/contributor add @rose00

@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2025

👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented May 7, 2025

@jdksjolen
Contributor John R Rose <[email protected]> successfully added.

@openjdk
Copy link

openjdk bot commented May 7, 2025

@jdksjolen The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@jdksjolen jdksjolen changed the title Rename ResolvedIndyEntry::set_flags to set_has_appendix 8356390 May 7, 2025
@openjdk openjdk bot changed the title 8356390 8356390: Rename ResolvedIndyEntry::set_flags to set_has_appendix May 7, 2025
@jdksjolen jdksjolen marked this pull request as ready for review May 7, 2025 13:46
@openjdk openjdk bot added the rfr Pull request is ready for review label May 7, 2025
@mlbridge
Copy link

mlbridge bot commented May 7, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant