Skip to content

8355515: Clarify the purpose of forcePass() and forceFail() methods #25091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manukumarvs
Copy link
Member

@manukumarvs manukumarvs commented May 7, 2025

Clarified the purpose of forcePass() and forceFail() methods and recommended usage of these methods.

forcePass() contained an incorrect sample; it's addressed by JDK-8355441.

The description of forceFail() has been expanded, too.

A new section in the description of the PassFailJFrame added to describe forcePass() and forceFail().


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355515: Clarify the purpose of forcePass() and forceFail() methods (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25091/head:pull/25091
$ git checkout pull/25091

Update a local copy of the PR:
$ git checkout pull/25091
$ git pull https://git.openjdk.org/jdk.git pull/25091/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25091

View PR using the GUI difftool:
$ git pr show -t 25091

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25091.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2025

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 7, 2025
@openjdk
Copy link

openjdk bot commented May 7, 2025

@manukumarvs The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented May 7, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant