-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8350596: [Linux] Increase default MaxRAMPercentage for containerized workloads #25086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
/label add hospot-gc-dev |
/csr needed |
❗ This change is not yet ready to be integrated. |
@jerboaa
|
/label add hotspot-gc |
@jerboaa |
Please take a look at this proposal to fix the "Java needs so much memory" perception in containers. The idea would be to bump the default
MaxRAMPercentage
to a higher value. The patch proposes 75%, but we could just as well use 50% if people feel more comfortable about it. Right now the default deployment in containers with resource limits in place (common for Kubernetes deployments) where a single process runs in the container isn't well catered for today for an application that just uses the default configuration. Only 25% of the container memory will be used for the Java heap, arguably wasting much of the remaining memory that has been granted to the container by a memory limit (that the JVM would detect and use as physical memory).I've filed a CSR for this as well for which I'm looking for reviewers too and intend to write a release note as well about this change as it has some risk associated with it, although the escape hatch is pretty simple: set
-XX:MaxRAMPercentage=25.0
to go back to the old behavour.Testing:
Thoughts? Opinions?
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25086/head:pull/25086
$ git checkout pull/25086
Update a local copy of the PR:
$ git checkout pull/25086
$ git pull https://git.openjdk.org/jdk.git pull/25086/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25086
View PR using the GUI difftool:
$ git pr show -t 25086
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25086.diff
Using Webrev
Link to Webrev Comment