8356320: GifImageDecoder can produce wrong image when GCE changes transparent pixel index #25076
+141
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge openjdk/jdk into mickleness/jdk
Merge openjdk/jdk
Merge from openjdk/jdk
Updating mickleness/jdk from openjdk/jdk
updating to openjdk/jdk
In this ticket the problem was: `tpix` was the transparent pixel index of the current `model`. However `decoder.saved_image` uses its own IndexColorModel (see `decoder.saved_model`). In a simple gif these two models are the same, but in this case the gif has some frames that change the transparent pixel index between frames. We were filling the wrong tpix value, resulting in an opaque rectangle.
|
👋 Welcome back mickleness! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@mickleness The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a gif frame's disposal code is DISPOSAL_BGCOLOR and we're maintaining a saved image: we have to flood-fill the frame's bounds. And if the transparent pixel index changes across frames: we could sometimes flood fill the wrong value, resulting in an opaque rectangle in the output image.
(I know this looks similar to #25044 , but if you look at the data structure of the sample gifs: they are separate problems with separate solutions.)
Progress
Warning
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25076/head:pull/25076$ git checkout pull/25076Update a local copy of the PR:
$ git checkout pull/25076$ git pull https://git.openjdk.org/jdk.git pull/25076/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25076View PR using the GUI difftool:
$ git pr show -t 25076Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25076.diff
Using Webrev
Link to Webrev Comment