-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade to latest openapi-fetch #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to a185e73 in 2 minutes and 19 seconds
More details
- Looked at
8272
lines of code in53
files - Skipped
3
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. sdks/sdk-openint/src/index.spec.ts:50
- Draft comment:
Consider adding assertions to verify the expected behavior of the component, such as checking the rendered output or the state of the component. - Reason this comment was not posted:
Confidence changes required:50%
The test case for 'swr-openapi integration' is missing an assertion to verify the expected behavior of the component. It currently only checks if the component is truthy, which doesn't confirm the integration works as intended.
Workflow ID: wflow_n266Gp1hUJrEnIri
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 104d476 in 1 minute and 3 seconds
More details
- Looked at
46
lines of code in3
files - Skipped
1
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. examples/test.cjs:1
- Draft comment:
The update fromveniceSdkDef
toopenintSdkDef
andvenice
toopenint
is consistent with the PR description and seems correct. - Reason this comment was not posted:
Confidence changes required:0%
The code changes in test.cjs and test.mjs are consistent with the PR description, which mentions updating the SDK from 'venice' to 'openint'. The changes are correct and align with the intent of the PR.
2. examples/test.mjs:1
- Draft comment:
The update fromveniceSdkDef
toopenintSdkDef
andvenice
toopenint
is consistent with the PR description and seems correct. - Reason this comment was not posted:
Confidence changes required:0%
The code changes in test.cjs and test.mjs are consistent with the PR description, which mentions updating the SDK from 'venice' to 'openint'. The changes are correct and align with the intent of the PR.
Workflow ID: wflow_rJ5I9MGSr7cKLEfi
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 43f79e8 in 51 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
1
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. examples/package.json:12
- Draft comment:
The upgrade to^0.0.20
for@opensdks/runtime
is appropriate for allowing non-breaking updates. Ensure that this version is compatible with the rest of the codebase. - Reason this comment was not posted:
Confidence changes required:20%
The upgrade of@opensdks/runtime
to^0.0.20
is consistent with the pattern of using caret (^) for versioning, which allows for non-breaking updates. This is a good practice for maintaining up-to-date dependencies without introducing breaking changes.
Workflow ID: wflow_is0mRyhFBK5Tpczi
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 99edc1c in 56 seconds
More details
- Looked at
56
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. sdks/sdk-qbo/src/index.ts:83
- Draft comment:
The type assertionas typeof client & typeof extension
is unnecessary here since TypeScript can infer the type correctly afterObject.assign
. Consider removing it for cleaner code. - Reason this comment was not posted:
Confidence changes required:50%
The use ofObject.assign
is correct, but the type assertion is unnecessary since the type is already inferred.
2. sdks/sdk-salesforce/src/index.ts:46
- Draft comment:
The type assertionas typeof client & typeof extension
is unnecessary here since TypeScript can infer the type correctly afterObject.assign
. Consider removing it for cleaner code. - Reason this comment was not posted:
Confidence changes required:50%
The use ofObject.assign
is correct, but the type assertion is unnecessary since the type is already inferred.
Workflow ID: wflow_9RfmPmwlYGoV6Tf2
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Upgrade
openapi-fetch
andopenapi-typescript
dependencies, update code for compatibility, and add integration tests forsdk-openint
.openapi-fetch
to^0.13.3
inexamples/package.json
.openapi-typescript
to^7.4.4
inpackages/cli/package.json
and multiple SDKs'package.json
files.astToString
ingenerateTypes()
inutils.ts
.createClient()
increateClient.ts
to usewrapAsPathBasedClient
and handle HTTP methods withUppercase<HttpMethod>
.openapi-react-query
andswr-openapi
integration inindex.spec.ts
forsdk-openint
.This description was created by for 99edc1c. It will automatically update as commits are pushed.