Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-openint): fixing auth #44

Merged
merged 9 commits into from
Dec 4, 2024
Merged

feat(sdk-openint): fixing auth #44

merged 9 commits into from
Dec 4, 2024

Conversation

pellicceama
Copy link
Collaborator

@pellicceama pellicceama commented Dec 4, 2024

Important

Enhances OpenInt SDK authentication, updates OpenAPI specifications, and bumps package version.

  • Authentication:
    • Added authLink and echoLink in index.spec.ts for testing authentication scenarios.
    • Implemented generateHeaders() in index.ts to construct headers for authentication.
    • Updated initOpenIntSDK() in index.ts to integrate generateHeaders() and handle auth options.
  • OpenAPI Specification:
    • Updated server URL in openint.oas.meta.ts to https://api.openint.dev/v0.
    • Added summaries and tags to various endpoints in openint.oas.json.
    • Introduced new endpoints for file storage operations in openint.oas.json.
  • Miscellaneous:
    • Bumped version in package.json from 0.0.12 to 0.0.15.
    • Added OpenIntProxyLinkOptions type in index.ts for better type handling.

This description was created by Ellipsis for b93ec70. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6277ee9 in 1 minute and 45 seconds

More details
  • Looked at 3465 lines of code in 7 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/sdk-openint/src/index.ts:34
  • Draft comment:
    Consider adding checks to ensure opts.auth and opts.auth.openInt are defined before accessing them to prevent potential runtime errors.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_3IofCDrMHs72VTsr


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on b93ec70 in 14 seconds

More details
  • Looked at 15 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/sdk-openint/src/index.ts:13
  • Draft comment:
    Ensure that the input for the authorization header is validated to match the Bearer ${string} format before assignment to prevent runtime errors.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_oVjmoyWi1tfvaBjW


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@pellicceama pellicceama merged commit 09dd857 into main Dec 4, 2024
0 of 2 checks passed
@pellicceama pellicceama deleted the unified-file-storage branch December 4, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant