-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-openint): fixing auth #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 6277ee9 in 1 minute and 45 seconds
More details
- Looked at
3465
lines of code in7
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. sdks/sdk-openint/src/index.ts:34
- Draft comment:
Consider adding checks to ensureopts.auth
andopts.auth.openInt
are defined before accessing them to prevent potential runtime errors. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_3IofCDrMHs72VTsr
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on b93ec70 in 14 seconds
More details
- Looked at
15
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. sdks/sdk-openint/src/index.ts:13
- Draft comment:
Ensure that the input for theauthorization
header is validated to match theBearer ${string}
format before assignment to prevent runtime errors. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_oVjmoyWi1tfvaBjW
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Enhances OpenInt SDK authentication, updates OpenAPI specifications, and bumps package version.
authLink
andechoLink
inindex.spec.ts
for testing authentication scenarios.generateHeaders()
inindex.ts
to construct headers for authentication.initOpenIntSDK()
inindex.ts
to integrategenerateHeaders()
and handleauth
options.openint.oas.meta.ts
tohttps://api.openint.dev/v0
.openint.oas.json
.openint.oas.json
.package.json
from0.0.12
to0.0.15
.OpenIntProxyLinkOptions
type inindex.ts
for better type handling.This description was created by for b93ec70. It will automatically update as commits are pushed.