updating sdk-openint OAS #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 9c797e7 in 1 minute and 1 seconds
More details
- Looked at
249lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_COcx7S7JRfyz3QOS
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| "responses": { | ||
| "200": { | ||
| "description": "Successful response", | ||
| "content": {"application/json": {"schema": {}}} |
There was a problem hiding this comment.
The response schema for the /unified/accounting/payment-receipt endpoint is empty. Consider defining the expected response structure for better clarity and type safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add new endpoints for bank accounts and payment receipts to sdk-openint OpenAPI spec and update TypeScript types.
/unified/accounting/bank-accountsendpoint withGETmethod for retrieving bank accounts by customer./unified/accounting/payment-receiptendpoint withGETmethod for retrieving payment receipts by customer transaction ID.openint.oas.types.d.tsto includeaccounting-getBankAccountsandaccounting-getPaymentReceiptsoperations.package.jsonfrom0.0.11to0.0.12.This description was created by
for 9c797e7. It will automatically update as commits are pushed.