feat: Microsoft graph SDK #40
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 01b06f8 in 24 seconds
More details
- Looked at
82lines of code in3files - Skipped
2files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_oUoDDANhznV7X717
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
master-manifest.ts
Outdated
| @@ -161,4 +161,7 @@ export default { | |||
| ], | |||
| ), | |||
| }, | |||
| msgraph: { | |||
| download: 'https://raw.githubusercontent.com/microsoftgraph/msgraph-sdk-powershell/refs/heads/dev/openApiDocs/v1.0/Files.yml', | |||
There was a problem hiding this comment.
The URL should point to a specific file or commit, not a branch reference, to ensure stability.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on cb392f9 in 11 seconds
More details
- Looked at
26lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. master-manifest.ts:166
- Draft comment:
Consider defining the Microsoft Graph SDK download URL as a constant to avoid duplication and potential errors if the URL changes. - Reason this comment was not posted:
Confidence changes required:50%
The URL for the Microsoft Graph SDK download is repeated in the master-manifest.ts file. It would be better to define it as a constant to avoid duplication and potential errors if the URL needs to be updated.
Workflow ID: wflow_ARHpOiIyBHgWvZXk
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
openint-bot
force-pushed
the
microsoft-graph
branch
from
cb392f9 to
23dbcf2
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 23dbcf2 in 9 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_wGhrJcmnTSukzzzA
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Important
Add Microsoft Graph SDK with new package setup and YAML support in utilities.
msgraphentry inmaster-manifest.tswith download URL for OpenAPI spec.package.jsoninsdks/sdk-msgraphfor package setup, including scripts for building and cleaning.tsconfig.build.jsoninsdks/sdk-msgraphfor TypeScript compilation settings.src/index.tsandsrc/msgraph.oas.meta.tsfor SDK initialization and metadata.prettyFormat()inutils.tsto supportyamlparser.syncManifest()ingenerateFromManifest.tsto handle YAML format.This description was created by
for 23dbcf2. It will automatically update as commits are pushed.