refactor: httpMethod

openintegrations · Dec 23, 2024 · 89479ae · 89479ae
1 parent cacb280
commit 89479ae
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 21 deletions.
diff --git a/packages/fetch-links/link.ts b/packages/fetch-links/link.ts
@@ -1,13 +1,17 @@
-/** TODO: Leverage typescript helper instead. */
-export type HTTPMethod =
-  | 'GET'
-  | 'PUT'
-  | 'POST'
-  | 'DELETE'
-  | 'OPTIONS'
-  | 'HEAD'
-  | 'PATCH'
-  | 'TRACE'
+import type {HttpMethod} from 'openapi-typescript-helpers'
+
+export const HTTP_METHODS = [
+  'GET',
+  'PUT',
+  'POST',
+  'DELETE',
+  'OPTIONS',
+  'HEAD',
+  'PATCH',
+  'TRACE',
+] satisfies ReadonlyArray<Uppercase<HttpMethod>>
+
+export type HTTPMethod = (typeof HTTP_METHODS)[number]
 
 /**
  * The BetterRequest object is an extension of the native [Request](https://developer.mozilla.org/en-US/docs/Web/API/Request)

diff --git a/packages/fetch-links/package.json b/packages/fetch-links/package.json
@@ -43,6 +43,7 @@
   "devDependencies": {
     "axios": "^1.6.2",
     "concurrently": "^8.2.2",
+    "openapi-typescript-helpers": "^0.0.15",
     "type-fest": "^4.28.0"
   },
   "publishConfig": {

diff --git a/packages/runtime/createClient.ts b/packages/runtime/createClient.ts
@@ -16,6 +16,7 @@ import {
   applyLinks,
   authLink,
   fetchLink,
+  HTTP_METHODS,
   // type HTTPMethod,
   type Link,
 } from '@opensdks/fetch-links'
@@ -39,17 +40,6 @@ export type OpenAPIClient<Paths extends {}> = ReturnType<
 // to get a list of servers and all that?
 // Really do feel that they should be generated as well..
 
-const HTTP_METHODS = [
-  'GET',
-  'PUT',
-  'POST',
-  'DELETE',
-  'OPTIONS',
-  'HEAD',
-  'PATCH',
-  'TRACE',
-] satisfies ReadonlyArray<Uppercase<HttpMethod>>
-
 export function createClient<
   Paths extends {},
   Media extends MediaType = MediaType,

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml