Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC2217 improvements #1337

Closed
wants to merge 1 commit into from
Closed

Conversation

wborn
Copy link
Member

@wborn wborn commented May 24, 2020

  • Rework workaround so binding can use undiscovered RFC2217 ports
  • Catch UnsupportedCommOperationException

See also:

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/solved-zwave-zigbee-rfc2217-remote-serial-port-howto/81633/69

* Rework workaround so binding can use undiscovered RFC2217 ports
* Catch UnsupportedCommOperationException

Signed-off-by: Wouter Born <[email protected]>
Copy link
Contributor

@bodiroga bodiroga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good! I will try to pick up a Raspberry Pi and test it in the Eclipse IDE!

Thank you @wborn!

@bodiroga
Copy link
Contributor

Hi @wborn!

In my own fork I have created a branch with even more improvements for the RFC2217 connection, here you have a link to it: https://github.com/bodiroga/org.openhab.binding.zwave/tree/rfc2217-improvements

How can we merge both changes? Can I make a pull request to your own branch? Can you manually add my changes?

@cdjackson, I can confirm that this improvements work great, and with my additions, it works even better. Finally we have a RFC2217 native implementation 😉

Thanks guys!

@RafalLukawiecki
Copy link

I am interested in any improvements to the RFC2217 reconnection logic, many thanks for your work.

@cdjackson
Copy link
Collaborator

cdjackson commented May 31, 2020

Thanks @bodiroga . I don't have any way to test this so I'll merge based on your tests. What I'd suggest is that if you've created changes on top of this PR, then you now create a new PR (adding this also-by signature to reference @wborn and we close this.

Thanks for looking at this - I know there are a few people that will be happy :)

@bodiroga
Copy link
Contributor

Done! #1341

@cdjackson
Copy link
Collaborator

Thanks @bodiroga. I'll close this and we can complete the discussion in #1341.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants