-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC2217 improvements #1337
RFC2217 improvements #1337
Conversation
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/solved-zwave-zigbee-rfc2217-remote-serial-port-howto/81633/69 |
* Rework workaround so binding can use undiscovered RFC2217 ports * Catch UnsupportedCommOperationException Signed-off-by: Wouter Born <[email protected]>
3dcc054
to
1934e4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good! I will try to pick up a Raspberry Pi and test it in the Eclipse IDE!
Thank you @wborn!
Hi @wborn! In my own fork I have created a branch with even more improvements for the RFC2217 connection, here you have a link to it: https://github.com/bodiroga/org.openhab.binding.zwave/tree/rfc2217-improvements How can we merge both changes? Can I make a pull request to your own branch? Can you manually add my changes? @cdjackson, I can confirm that this improvements work great, and with my additions, it works even better. Finally we have a RFC2217 native implementation 😉 Thanks guys! |
I am interested in any improvements to the RFC2217 reconnection logic, many thanks for your work. |
Thanks @bodiroga . I don't have any way to test this so I'll merge based on your tests. What I'd suggest is that if you've created changes on top of this PR, then you now create a new PR (adding this Thanks for looking at this - I know there are a few people that will be happy :) |
Done! #1341 |
See also: