Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes OH 1.x XML support #788

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Removes OH 1.x XML support #788

merged 2 commits into from
Jul 10, 2024

Conversation

digitaldan
Copy link
Contributor

See #756

@digitaldan
Removes OH 1.x XML support
9a43663 
See openhab#756

Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan digitaldan requested review from timbms and weakfl July 8, 2024 18:32
@digitaldan
Copy link
Contributor Author

So this is the last thing on the checklist. This seems to work fine against my system and the openHAB demo server, so i'm inclined to merge it and move on 👍

@weakfl
Copy link
Contributor

weakfl commented Jul 9, 2024 •
edited
Loading

@digitaldan I guess the Fuzi dependency can be removed as well?

EDIT:
In the general project settings and and in the OpenHABCore package manifest:

openhab-ios/OpenHABCore/Package.swift

Line 19 in 4bb2207

.package(name: "Fuzi", url: "https://github.com/cezheng/Fuzi.git", from: "3.0.0"),

@digitaldan
Copy link
Contributor Author

Excellent catch, thanks!

@digitaldan
remove Fuzi library
ef718ef 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan digitaldan merged commit dcb390a into openhab:develop Jul 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbms timbms Awaiting requested review from timbms

@weakfl weakfl Awaiting requested review from weakfl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@digitaldan @weakfl