Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename app id to org.openhab.app #762

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Rename app id to org.openhab.app #762

merged 2 commits into from
Jun 1, 2024

Conversation

digitaldan
Copy link
Contributor

See #756

digitaldan added 2 commits May 28, 2024 19:20
@digitaldan
Rename app id to org.openhab.app
d43247d 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
Updated Google Firebase Config
c3d27d4 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan digitaldan requested review from weakfl and timbms May 30, 2024 20:15
@digitaldan
Copy link
Contributor Author

@timbms @weakfl everyone ok with the changes here? I updated our Google Firebase account to add this bundle id, so messaging and crash analytics should continue to work (but not yet tested, will do so shortly)

@timbms
Copy link
Contributor

timbms commented May 31, 2024

Fine with me. With all the hassle we will at least have an id within the openhab namespace

@digitaldan
Copy link
Contributor Author

Just tested and notifications work with our production cloud service which is nice.

@digitaldan digitaldan merged commit a20f2da into openhab:develop Jun 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weakfl weakfl Awaiting requested review from weakfl

@timbms timbms Awaiting requested review from timbms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@digitaldan @timbms