[legacy] adds new check for updated app and provides an in app upgrade experience #418
digitaldanpull_requests.yml
on: pull_request
build_and_test
21m 44s
Annotations
2 errors and 11 warnings
|
build_and_test
Error: Executing lane unittests failed.
|
|
build_and_test
Executing lane unittests failed.
|
|
build_and_test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, maierj/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
build_and_test:
OpenHABCore/Sources/OpenHABCore/Model/OpenHABItem.swift#L162
Line Length Violation: Line should be 250 characters or less; currently it has 302 characters (line_length)
|
|
build_and_test:
openHAB/LegacyNoticeViewController.swift#L30
Private Actions Violation: IBActions should be private (private_action)
|
|
build_and_test:
openHAB/LegacyNoticeViewController.swift#L18
Type Contents Order Violation: An 'ib_outlet' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
|
|
build_and_test:
openHAB/OpenHABRootViewController.swift#L248
Empty Parentheses with Trailing Closure Violation: When using trailing closures, empty parentheses should be avoided after the method call (empty_parentheses_with_trailing_closure)
|
|
build_and_test:
openHAB/AppDelegate.swift#L115
value 'self' was defined but never used; consider replacing with boolean test
|
|
build_and_test:
ld#L1
object file (/Users/runner/Library/Developer/Xcode/DerivedData/openHAB-hdmskvjkthdvwkcszppuayfklhyw/Build/Products/Debug-iphonesimulator/SVGKit.o) was built for newer 'iOS-simulator' version (13.0) than being linked (12.0)
|
|
build_and_test
The CFBundleVersion of an app extension ('1580410538') must match that of its containing parent app ('1580410539').
|
|
build_and_test:
OpenHABCore/Sources/OpenHABCore/Model/OpenHABItem.swift#L162
Line Length Violation: Line should be 250 characters or less; currently it has 302 characters (line_length)
|
|
build_and_test:
openHAB/LegacyNoticeViewController.swift#L30
Private Actions Violation: IBActions should be private (private_action)
|
|
build_and_test:
openHAB/LegacyNoticeViewController.swift#L18
Type Contents Order Violation: An 'ib_outlet' should not be placed amongst the type content(s) 'instance_property' (type_contents_order)
|