Change Open Container source annotation to the openHAB distro repository #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
reviewed
Oct 31, 2024
There was a problem hiding this comment.
https://specs.opencontainers.org/image-spec/annotations/:
org.opencontainers.image.source URL to get source code for building the image (string)
The changes in this PR make it more difficult for developers to find the image source code. AFAIK the main use of the annotation is to simplify finding and inspecting the image source code and also use it for building your own images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the OpenContainer (OCI) image source annotation value to the openhab-distro repository URL.
Tools like Dependabot and Renovate use this Docker image label when opening PRs for dependency updates. The URL allows these tools to show detailed information about image changes (release notes, changelog entries), making it easier for developers to evaluate the impact of updates.
openHAB uses a separate (this) repository to build Docker images, but neither GitHub releases nor Changelog entries are maintained in this repo. This information is present in the openhab-distro repository instead.
When we change the
org.opencontainers.image.sourcelabel value to the distro package, we enable these tools to fetch the proper information that is being published with new releases, improving the integration of our images with existing and widely used dependency management tools.