Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nrjavaserial in TP to 5.2.1 #1503

Merged
merged 1 commit into from
May 27, 2020

Conversation

wborn
Copy link
Member

@wborn wborn commented May 27, 2020

With this version it will no longer completely exit ❗ the JVM in certain scenarios when ports are closed/reopened.

Related to:

With this version it will no longer completely exit the JVM in certain scenarios when ports are closed/reopened.

Related to:

* openhab/org.openhab.binding.zigbee#577
* openhab/org.openhab.binding.zwave#1332

Signed-off-by: Wouter Born <[email protected]>
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

What about the compile BOM?

@wborn
Copy link
Member Author

wborn commented May 27, 2020

It should not be updated because the API is still compatible with 3.12. If it would be updated Bnd will raise the lower bound of the version range in package dependencies. So the framework will be compatible with more versions if we use older compile dependencies. This way you can still easily downgrade the nrjavaserial bundle in your openHAB instance with an older version if you run into some blocking issue.

@cweitkamp
Copy link
Contributor

Thanks for explaining again. Now I can remember that you told it before.

@cweitkamp cweitkamp added this to the 3.0 milestone May 27, 2020
@cweitkamp cweitkamp merged commit 5b325aa into openhab:master May 27, 2020
@wborn wborn deleted the nrjavaserial-5.2.1 branch May 27, 2020 19:31
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
With this version it will no longer completely exit the JVM in certain scenarios when ports are closed/reopened.

Related to:

* openhab/org.openhab.binding.zigbee#577
* openhab/org.openhab.binding.zwave#1332

Signed-off-by: Wouter Born <[email protected]>
GitOrigin-RevId: 5b325aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants