Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[basicprofiles] Convert to relative unit in State Filter's Delta check #18127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 19, 2025

@jimtng jimtng requested a review from J-N-K as a code owner January 19, 2025 00:35
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/state-filter-range-filter-profile/158025/58

@jimtng jimtng force-pushed the statefilter-delta-relativeunit branch from 470b991 to 3c248fa Compare January 19, 2025 01:30
@jimtng jimtng changed the title [basicprofiles] Fix delta comparison for relative units in State Filter [basicprofiles] Convert to relative unit in State Filter's Delta check Jan 19, 2025
@andrewfg
Copy link
Contributor

@jimtng please have a look at #18122

@jimtng
Copy link
Contributor Author

jimtng commented Jan 20, 2025

@jimtng please have a look at #18122

#18122 (comment)

I'll address that in another PR once the current PR backlog to StateFilter has been merged, just to avoid having to deal with merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants