Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gpstracker] Fix handling ambigious region names #17805

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[gpstracker] Fix handling ambigious region names #17805

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e05825
Fix regionname
lsiepel Nov 25, 2024
a8f4ef1
Fix SAT
lsiepel Nov 25, 2024
2127df5
Improve log line
lsiepel Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .../java/org/openhab/binding/gpstracker/internal/profile/GPSTrackerTriggerSwitchProfile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,16 @@ public void onStateUpdateFromItem(State state) {

@Override
public void onTriggerFromHandler(String payload) {
if (payload.startsWith(regionName)) {
OnOffType state = OnOffType.from(payload.endsWith("enter"));
if (!payload.contains("/")) {
logger.debug("Transition trigger with mallformed payload: '{}', missing '\''", payload);
return;
}
String[] splitted = payload.split("/");
if (splitted[0].equals(regionName)) {
OnOffType state = OnOffType.from("enter".equals(splitted[1]));
callback.sendCommand(state);
logger.debug("Transition trigger {} handled for region {} by profile: {}", payload, regionName, state);
logger.debug("Transition trigger with payload: '{}' handled for region {} by profile: {}", payload,
regionName, state);
}
}
}