Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deconz] Distinguish thing action scope across the binding #17788

Closed
wants to merge 2 commits into from
Closed

[deconz] Distinguish thing action scope across the binding #17788

wants to merge 2 commits into from

Conversation

clinique
Copy link
Contributor

In response to issue #17785

@clinique clinique requested a review from J-N-K as a code owner November 22, 2024 13:36
@jlaur
Copy link
Contributor

jlaur commented Dec 1, 2024

Considering #17785 (comment), is this really needed (and why)?

@J-N-K
Copy link
Member

J-N-K commented Dec 1, 2024 •
edited
Loading

This is not needed and represents an unnecessary breaking change. Until a good argument emerges, I put a veto on merging.

@lolodomo
Copy link
Contributor

lolodomo commented Dec 1, 2024

Closing it if not needed

@lolodomo lolodomo closed this Dec 1, 2024
@clinique clinique deleted the deconz_17785 branch December 16, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K Awaiting requested review from J-N-K J-N-K is a code owner

Assignees
No one assigned
Labels
(potentially) not backward compatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clinique @jlaur @J-N-K @lolodomo