[ism8] Prevent sending for read-only channel types #17760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands from sitemap elements will not be sent to ISM8 when read-only channel types are used. Auto-update policy is set to veto to prevent state change. Signed-off-by: Holger Friedrich <[email protected]>
holgerfriedrich
added
enhancement
holgerfriedrich
removed
the
additional testing preferred
|
Additional testing done on live system. I works as expected. |
lsiepel
reviewed
Nov 30, 2024
...es/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/internal/Ism8Handler.java
Outdated
Show resolved
Hide resolved
…ding/ism8/internal/Ism8Handler.java Signed-off-by: lsiepel <[email protected]>
lsiepel
approved these changes
Nov 30, 2024
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Dec 16, 2024
* [ism8] Prevent sending for read-only channel types Signed-off-by: Holger Friedrich <[email protected]>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
* [ism8] Prevent sending for read-only channel types Signed-off-by: Holger Friedrich <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISM8 binding defines a few read-only channel types, e.g.
switch-r.With this PR, commands from sitemap elements will not be sent to ISM8 when read-only channel types are used.
Auto-update policy is set to veto to prevent state change.
One missing readonly attribute added (mode-r).