Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openaitts] OpenAI Text-to-Speech initial contribution #17733

Merged
merged 37 commits into from
Dec 24, 2024
Merged

[openaitts] OpenAI Text-to-Speech initial contribution #17733

merged 37 commits into from
Dec 24, 2024

Conversation

Artur-Fedjukevits
Copy link
Contributor

The OpenAI TTS (Text-to-Speech) addon for openHAB allows you to integrate OpenAI's Text-to-Speech capabilities into your openHAB system. The advantage of this service over others is that one selected voice can speak different languages. This is useful, for example, in conjunction with chatGPT binding, which will help in learning foreign languages.

Compiled jar - https://fedjukevitsh.com/s/TeaDeLCKSTjD7Yi

@Artur-Fedjukevits
OpenAI TTS
b1594c1 
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits Artur-Fedjukevits requested a review from a team as a code owner November 11, 2024 11:33
@Artur-Fedjukevits
pom.xml
aeacec2 
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits
codeowners & pom
1f99be6 
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits
spotless
b017038 
Signed-off-by: Artur-Fedjukevits <[email protected]>
jlaur
jlaur reviewed Nov 11, 2024
View reviewed changes
Artur-Fedjukevits and others added 3 commits November 12, 2024 12:15
@Artur-Fedjukevits @jlaur
Update bundles/org.openhab.voice.openaitts/src/main/resources/OH-INF/…
c1c5892 
…addon/addon.xml

Co-authored-by: Jacob Laursen <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits @jlaur
Update bundles/org.openhab.voice.openaitts/pom.xml
8804832 
Co-authored-by: Jacob Laursen <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits
codeowners
bc34e03 
Signed-off-by: Artur-Fedjukevits <[email protected]>
wborn
wborn requested changes Dec 8, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 👍

I also added a few comments:

wborn
wborn reviewed Dec 8, 2024
View reviewed changes
wborn
wborn reviewed Dec 8, 2024
View reviewed changes
Artur-Fedjukevits and others added 11 commits December 9, 2024 08:33
@Artur-Fedjukevits @wborn
Update bundles/org.openhab.voice.openaitts/src/main/java/org/openhab/…
a14d55b 
…voice/openaitts/internal/OpenAITTSService.java

Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits @wborn
Update bundles/org.openhab.voice.openaitts/README.md
5a453bb 
Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits @wborn
Update bundles/org.openhab.voice.openaitts/README.md
ccc8c4d 
Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits @wborn
Update bundles/org.openhab.voice.openaitts/src/main/java/org/openhab/…
4cecad0 
…voice/openaitts/internal/OpenAITTSService.java

Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits @wborn
Update bundles/org.openhab.voice.openaitts/src/main/java/org/openhab/…
df73ec8 
…voice/openaitts/internal/OpenAITTSService.java

Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits @wborn
Update bundles/org.openhab.voice.openaitts/src/main/java/org/openhab/…
56957dd 
…voice/openaitts/internal/OpenAITTSService.java

Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits @wborn
Update bundles/org.openhab.voice.openaitts/src/main/resources/OH-INF/…
13a6654 
…config/config.xml

Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits @wborn
Update bundles/org.openhab.voice.openaitts/src/main/resources/OH-INF/…
2bece04 
…config/config.xml

Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits @wborn
Update bundles/org.openhab.voice.openaitts/src/main/java/org/openhab/…
b05397a 
…voice/openaitts/internal/OpenAITTSService.java

Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits
@wborn comments
2748d2f 
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits @wborn
Update pom.xml
68a3db1 
Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
wborn
wborn requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a few more improvements after scrolling through the code again:

Artur-Fedjukevits and others added 8 commits December 12, 2024 21:22
@Artur-Fedjukevits @wborn
Update bundles/org.openhab.voice.openaitts/README.md
0ae8753 
Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits @wborn
Update bundles/org.openhab.voice.openaitts/src/main/resources/OH-INF/…
88283e3 
…config/config.xml

Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits @wborn
Update bundles/org.openhab.voice.openaitts/README.md
e23977c 
Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits @wborn
Update bundles/org.openhab.voice.openaitts/pom.xml
dcf2ea6 
Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits @wborn
Update bundles/org.openhab.voice.openaitts/src/main/java/org/openhab/…
74d9a83 
…voice/openaitts/internal/OpenAITTSVoice.java

Co-authored-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits
config.xml
c3e88d2 
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits
config.xml
38cd20d 
Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits
Merge branch 'openhab:main' into openai-tts
efbb46d
wborn
wborn requested changes Dec 14, 2024
View reviewed changes
@wborn wborn changed the title [openaitts] OpenAI Text-to-Speech binding (new) [openaitts] OpenAI Text-to-Speech initial contribution Dec 14, 2024
@Artur-Fedjukevits
Delete .vs directory
457f913 
Signed-off-by: Artur-Fedjukevits <[email protected]>
wborn
wborn requested changes Dec 15, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments!
I also gave it a brief test today and it seems to work fine. 👍
Here are a few more comments I ran into while testing the add-on:

@wborn
Copy link
Member

wborn commented Dec 19, 2024

Yes yes very good. 👍
I'll soon have another look as it is almost holiday time. 🎄 ⛄

wborn added 2 commits December 24, 2024 18:12
@wborn
Fix capitalization
2b2911f 
Signed-off-by: Wouter Born <[email protected]>
@wborn
Add missing default translations
8870120 
Signed-off-by: Wouter Born <[email protected]>
wborn
wborn approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! It works very well now. 🙂 👍

@wborn wborn merged commit 7c6e658 into openhab:main Dec 24, 2024
3 checks passed
@wborn wborn added this to the 5.0 milestone Dec 24, 2024
@felixschndr
Copy link
Contributor

Compiled jar - https://fedjukevitsh.com/s/TeaDeLCKSTjD7Yi

Does this jar work for 4.3.0 as well or is it only compatible with 5.0?

@Artur-Fedjukevits Artur-Fedjukevits deleted the openai-tts branch December 27, 2024 08:31
@Artur-Fedjukevits
Copy link
Contributor Author

Compiled jar - https://fedjukevitsh.com/s/TeaDeLCKSTjD7Yi

Does this jar work for 4.3.0 as well or is it only compatible with 5.0?

Yes, that jar was compiled for 4.3

DrRSatzteil pushed a commit to DrRSatzteil/openhab-addons that referenced this pull request Jan 3, 2025
@Artur-Fedjukevits @DrRSatzteil
[openaitts] OpenAI Text-to-Speech initial contribution (openhab#17733)
8b58d48 
Also-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
chilobo pushed a commit to chilobo/openhab-addons that referenced this pull request Feb 10, 2025
@Artur-Fedjukevits @chilobo
[openaitts] OpenAI Text-to-Speech initial contribution (openhab#17733)
668fa7b 
Also-by: Wouter Born <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
Signed-off-by: Christian Koch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur left review comments

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
new voice
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Artur-Fedjukevits @wborn @felixschndr @jlaur