[smsmodem] Initial contribution #12250

dalgwen · 2022-02-09T01:23:03Z

This binding connects to a USB serial GSM modem (or a network exposed one, a.k.a ser2net) and allows openHAB to send and receive SMS through it.
With this binding, there is no need for complex configuration with external tools, such as gammu.

Here is the community discussion, where you can find a binary snapshot.

This binding uses smslibv4, directly included (org.openhab.binding.smsmodem.internal.smslib packages and sub packages) and heavily refactored to pass openHAB code standard. I asked on the forum if it was OK and decided to go on with the inclusion. Hope this is OK. Honestly, I don't understand everything in this library : SMS is a complex standard and I didn't take the time to grab it as the smslibv4 was here for me to hide the complexity.

The code still has a "deviation" from the openHAB standard : in the internal smslib, it uses a manually created Thread to continuously read from the serial port (the PollReader class). As the thread is continuously running, I thought it could be a valid use case (to not take forever a thread from the openHAB pool). If you don't think so, please tell me and I will refactor it.

Hilbrand · 2022-02-09T08:47:32Z

There are other add-ons that include third party code. But because it's under a different license this needs to be added differently. You need to put the sources in a different map: src/3thparty/java/ and than you can keep the original package and such, and add the directory to the pom.xml. See for example the smartmeter binding: https://github.com/openhab/openhab-addons/tree/main/bundles/org.openhab.binding.smartmeter. Don't

The way you have added it now seems to me illegal as you have changed the license on the 3rd party source code. Which you only can do if you are the copyright owner of the source code.

Regarding threads. It's ok to have an own thread. In fact if you have long running threads you must create them as only short running threads are allowed on the scheduled executor. See also #8216 about naming the thread and do setDeamon(true).

dalgwen · 2022-02-09T22:56:23Z

Hello @Hilbrand,

Thank you very much for these informations.
Indeed, the way I included the code from smslib was problematic and I'm glad you directed me to a valid solution.
So, I did as you said, and refactored the inclusion. For information :

I put back the smslib code in the org.smslib package
I put this package and subpackages in the src/3rdparty/java folder
I deleted the openHAB copyright information I had improperly added on top of every org.smslib file (though I let the mention "extracted from smslib" that I had put before).
I completed the NOTICE file and the pom.xml with relevant information (I took the smartmeter binding as a model)

I also put a name and the daemon property on the always living thread polling the device.

bundles/org.openhab.binding.smsmodem/pom.xml

fwolter · 2022-07-10T18:24:02Z

@dalgwen It's been a long time you submitted your new addon. Are you still around to implement upcoming review feedback?

dalgwen · 2022-07-10T18:35:19Z

Yes, I would be happy to do so.
I use this binding every day and also provide support on the forum for the (very) few interested users.

But I'm aware that it doesn't attract many people and is low on the priority list... so no problem if it takes time !

Thanks,

fwolter

I reviewed the readme so far.

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html after building it with mvn clean install.

bundles/org.openhab.binding.smsmodem/README.md

This binding connects to a USB serial GSM modem (or a network exposed one, a.k.a ser2net) and allows openHAB to send and receive SMS through it. Signed-off-by: Gwendal Roulleau <[email protected]>

Signed-off-by: Gwendal Roulleau <[email protected]>

And long running thread naming convention And treated some code warning Signed-off-by: Gwendal Roulleau <[email protected]>

Signed-off-by: Gwendal Roulleau <[email protected]>

update channel rename action to avoid colision with other binding and a too generic name Signed-off-by: Gwendal Roulleau <[email protected]>

Signed-off-by: Gwendal Roulleau <[email protected]>

For non latin character in SMS Signed-off-by: Gwendal Roulleau <[email protected]>

Signed-off-by: Gwendal Roulleau <[email protected]>

dalgwen · 2022-07-11T22:55:42Z

Thank you @fwolter !
I checked the code-analysis but the report says there is no issue now.
Do you still have some ?

fwolter · 2022-08-14T13:49:38Z

I checked the code-analysis but the report says there is no issue now.

Looks good! Just give me a note if you want to change the modelling of the bridge or whether I shall continue reviewing.

dalgwen · 2022-08-20T11:21:42Z

Thank you @fwolter
You know better than me the good usage 👍, I will change the modelling of the bridge

Signed-off-by: Gwendal Roulleau <[email protected]>

dalgwen · 2022-08-22T22:40:08Z

As proposed, I split the bridge thing-type in two different bridge thing-types.
Binding is now ready for review.

fwolter · 2022-09-18T14:50:31Z

...ing.smsmodem/src/main/java/org/openhab/binding/smsmodem/internal/SMSModemHandlerFactory.java

+    }
+
+    public static ThingUID getSMSConversationUID(ThingTypeUID thingTypeUID, String recipient, ThingUID bridgeUID) {
+        return new ThingUID(thingTypeUID, recipient, bridgeUID.getId());


Looks like you are derivating the ThingUID from the phone number, but the ThingUID should be configureable by the user. Is there any reason not letting the user set the ThingUID?

The "getSMSConversationUID" method is called by the autodiscovery method, or from the createThing method if and only if the "thingUID" is null.
With this method, I want to give a default UID, IF NOT set by the user. If the user set the thing UID, it will use the user's one.
Your comment seems to mean that this approach is invalid, or do you mean it's badly implemented ?

In SMSConversationDiscoveryService you are calling getSMSConversationUID() directly, when creating the discovered Thing (which is the right approach). So, the default-ThingUID-use-case is handled there.

If the user adds the Thing manually, the ThingUID can't be left empty/null (neither via UI nor text based configuration).

What use case do you intend to handle by this code?

No particular use case here. I was just trying to implement the createThing method from the parent class and respecting the annotation : in this method, the parameter thingUID is nullable.
If you thing it is best, I can remove the call to the getSMSConversationUID in createThing, but the compiler will log a warning I guess ?
Or I could fail fast with an exception if thingUID is null.
What do you think ?

Just for clarification, createThing() doesn't need to be implemented by bindings. It's sufficient to implement createHandler(). You could remove createThing() entirely.

Oh my ! I wouldn't have wasted your time if I knew that before... Sorry 😨
Deleted !

...msmodem/src/main/java/org/openhab/binding/smsmodem/internal/SMSModemBridgeConfiguration.java

...ng.smsmodem/src/main/java/org/openhab/binding/smsmodem/internal/actions/SMSModemActions.java

...odem/src/main/java/org/openhab/binding/smsmodem/internal/handler/SMSConversationHandler.java

fwolter · 2022-09-18T15:00:01Z

...odem/src/main/java/org/openhab/binding/smsmodem/internal/handler/SMSConversationHandler.java

+    private void setStatusByBridgeStatus() {
+        SMSModemBridgeHandler bridgeHandlerFinal = bridgeHandler;
+        if (bridgeHandlerFinal != null) {
+            switch (bridgeHandlerFinal.getThing().getStatus()) {
+                case INITIALIZING:
+                    updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.BRIDGE_OFFLINE);
+                    break;
+                case OFFLINE:
+                    updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.BRIDGE_OFFLINE);
+                    break;
+                case ONLINE:
+                    updateStatus(ThingStatus.ONLINE, ThingStatusDetail.NONE);
+                    break;
+                case REMOVED:
+                    updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.BRIDGE_OFFLINE);
+                    break;
+                case REMOVING:
+                    updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.BRIDGE_OFFLINE);
+                    break;
+                case UNINITIALIZED:
+                    updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.BRIDGE_OFFLINE);
+                    break;
+                case UNKNOWN:
+                    updateStatus(ThingStatus.UNKNOWN, ThingStatusDetail.BRIDGE_OFFLINE);
+                    break;
+            }
+        } else {
+            updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.BRIDGE_OFFLINE);
+        }


The Thing status is set by the framework automatically according the bridge status, if you set the Thing status to UNKNOWN in initialize(). Then, this could be removed.

I made a test and if I set the child handler status to "UNKNOWN" and leave if for the Bridge to update (deleting setStatusByBridgeStatus() method), it stays "UNKNOWN", even if the bridge status switch to "online".
Or maybe I didn't understand your proposition ?

By reading code, the bridgeStatusChanged() method of BaseThingHandler effectively change the child handler status to "ONLINE" when the bridge get online, but only if the last status details was BRIDGE_OFFLINE

You still need to set the child Thing ONLINE, if you think it is online. In your case this might be always the case, if the bridge is online. So, you can set it ONLINE in initialize() directly. Then, it will be online if the bridge is online and offline if the bridge is offline.

You only need to set it to UNKNOWN (and later to ONLINE) if you don't know the state in initialize(), yet.

Ah, I get it now !
Indeed, I can set it to ONLINE directly.
Done, thanks

By the way, there is one drawback : the bridge start as "unknown" because it has to establish connection. But the smsconversation thing is immediately online at this time (and the status doesn't reflect the reality : it is not fully functionnal because of the bridge).

Just tested your code and a reason why it doesn't work as expected is that you don't set the ThingStatus in the bridge's initialize() to UNKNOWN. It works for me if I do that.

Strange, it doesn't work for me. When the bridge is initializing (unknown), the child conversation thing is online. Maybe an order initialization issue ?
But it is no big deal, I'm OK with that, so I let you decide if it needs further investigation.

I just tested it again and you're right, as long as the bridge is in UNKNOWN state, the child Things are ONLINE. Only if the bridge is set to OFFLINE, the child Things are set to OFFLINE, too. Normally you wouldn't notice, because the bridge stays in UNKNOWN state only for very short time. In this case the timeout is quite long.

I would expect the SMS modem to respond within subseconds and would chose a shorter timeout, anyway. But maybe there are things I didn't consider.

I merge it for now. If you want to improve the behavior, you could file a follow-up PR.

...modem/src/main/java/org/openhab/binding/smsmodem/internal/handler/SMSModemBridgeHandler.java

bundles/org.openhab.binding.smsmodem/src/main/resources/OH-INF/binding/binding.xml

bundles/org.openhab.binding.smsmodem/src/main/resources/OH-INF/thing/smsmodem.xml

Signed-off-by: Gwendal Roulleau <[email protected]>

fwolter · 2022-11-20T10:49:05Z

...ing.smsmodem/src/main/java/org/openhab/binding/smsmodem/internal/SMSModemHandlerFactory.java

+    }
+
+    public static ThingUID getSMSConversationUID(ThingTypeUID thingTypeUID, String recipient, ThingUID bridgeUID) {
+        return new ThingUID(thingTypeUID, recipient, bridgeUID.getId());


Just for clarification, createThing() doesn't need to be implemented by bindings. It's sufficient to implement createHandler(). You could remove createThing() entirely.

bundles/org.openhab.binding.smsmodem/src/main/resources/OH-INF/thing/smsmodem.xml

fwolter · 2022-11-20T11:12:12Z

...modem/src/main/java/org/openhab/binding/smsmodem/internal/handler/SMSModemBridgeHandler.java

+        } catch (ModemConfigurationException e) {
+            String message = e.getMessage();
+            logger.error(message, e);
+            updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, message);


This is what I saw. That sounds more like a configuration error. I leave it up to you what makes more sense.

fwolter · 2022-11-20T11:16:18Z

...odem/src/main/java/org/openhab/binding/smsmodem/internal/handler/SMSConversationHandler.java

+    private void setStatusByBridgeStatus() {
+        SMSModemBridgeHandler bridgeHandlerFinal = bridgeHandler;
+        if (bridgeHandlerFinal != null) {
+            switch (bridgeHandlerFinal.getThing().getStatus()) {
+                case INITIALIZING:
+                    updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.BRIDGE_OFFLINE);
+                    break;
+                case OFFLINE:
+                    updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.BRIDGE_OFFLINE);
+                    break;
+                case ONLINE:
+                    updateStatus(ThingStatus.ONLINE, ThingStatusDetail.NONE);
+                    break;
+                case REMOVED:
+                    updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.BRIDGE_OFFLINE);
+                    break;
+                case REMOVING:
+                    updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.BRIDGE_OFFLINE);
+                    break;
+                case UNINITIALIZED:
+                    updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.BRIDGE_OFFLINE);
+                    break;
+                case UNKNOWN:
+                    updateStatus(ThingStatus.UNKNOWN, ThingStatusDetail.BRIDGE_OFFLINE);
+                    break;
+            }
+        } else {
+            updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.BRIDGE_OFFLINE);
+        }


Just tested your code and a reason why it doesn't work as expected is that you don't set the ThingStatus in the bridge's initialize() to UNKNOWN. It works for me if I do that.

fwolter · 2022-11-20T11:17:27Z

...modem/src/main/java/org/openhab/binding/smsmodem/internal/handler/SMSModemBridgeHandler.java

+
+    @Override
+    public void initialize() {
+        shouldRun = true;


This is necessary to make the thing status automatism work.

Suggested change

shouldRun = true;

updateStatus(ThingStatus.UNKNOWN);

shouldRun = true;

Done !
Thank you (again)

Signed-off-by: Gwendal Roulleau <[email protected]>

fwolter

LGTM
Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

dalgwen · 2022-12-04T08:52:54Z

Great, thank you again for your time !

lolodomo · 2022-12-04T09:07:08Z

As the French translations were included on the PR, they have to be uploaded manually in Crowdin.

lolodomo · 2022-12-04T09:12:04Z

@dalgwen : you forgot adding an entry in CODEOWNERS file, can you please submit a small PR for that?

dalgwen · 2022-12-04T09:33:01Z

As the French translations were included on the PR, they have to be uploaded manually in Crowdin.

First time in crowdin for me. I think I did what you suggest. With some fixes after viewing warnings from crowdin.

you forgot adding an entry in CODEOWNERS file, can you please submit a small PR for that?

Oops, sorry. Done here.

lolodomo · 2022-12-04T12:15:15Z

First time in crowdin for me. I think I did what you suggest. With some fixes after viewing warnings from crowdin.

I have validated with few changes.
Syncing is in progress, the PR should be created in few minutes.

* [smsmodem] Initial contribution This binding connects to a USB serial GSM modem (or a network exposed one, a.k.a ser2net) and allows openHAB to send and receive SMS through it. Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] README fix Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] build/spotless fix Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] compliance with 3rd party license And long running thread naming convention And treated some code warning Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] i18n Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Small fixes update channel rename action to avoid colision with other binding and a too generic name Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Use of standard Thing properties Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Fix sender identifier error with special character Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Add encoding parameter For non latin character in SMS Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply review Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Split local and remote modem in two thing-types Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply review Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply review Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply code review (removing unnecessary method) Signed-off-by: Gwendal Roulleau <[email protected]> Signed-off-by: Gwendal Roulleau <[email protected]> Co-authored-by: Gwendal Roulleau <[email protected]> Signed-off-by: Ben Rosenblum <[email protected]>

* [smsmodem] Initial contribution This binding connects to a USB serial GSM modem (or a network exposed one, a.k.a ser2net) and allows openHAB to send and receive SMS through it. Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] README fix Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] build/spotless fix Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] compliance with 3rd party license And long running thread naming convention And treated some code warning Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] i18n Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Small fixes update channel rename action to avoid colision with other binding and a too generic name Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Use of standard Thing properties Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Fix sender identifier error with special character Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Add encoding parameter For non latin character in SMS Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply review Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Split local and remote modem in two thing-types Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply review Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply review Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply code review (removing unnecessary method) Signed-off-by: Gwendal Roulleau <[email protected]> Signed-off-by: Gwendal Roulleau <[email protected]> Co-authored-by: Gwendal Roulleau <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>

* [smsmodem] Initial contribution This binding connects to a USB serial GSM modem (or a network exposed one, a.k.a ser2net) and allows openHAB to send and receive SMS through it. Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] README fix Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] build/spotless fix Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] compliance with 3rd party license And long running thread naming convention And treated some code warning Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] i18n Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Small fixes update channel rename action to avoid colision with other binding and a too generic name Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Use of standard Thing properties Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Fix sender identifier error with special character Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Add encoding parameter For non latin character in SMS Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply review Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Split local and remote modem in two thing-types Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply review Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply review Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply code review (removing unnecessary method) Signed-off-by: Gwendal Roulleau <[email protected]> Signed-off-by: Gwendal Roulleau <[email protected]> Co-authored-by: Gwendal Roulleau <[email protected]>

* [smsmodem] Initial contribution This binding connects to a USB serial GSM modem (or a network exposed one, a.k.a ser2net) and allows openHAB to send and receive SMS through it. Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] README fix Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] build/spotless fix Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] compliance with 3rd party license And long running thread naming convention And treated some code warning Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] i18n Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Small fixes update channel rename action to avoid colision with other binding and a too generic name Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Use of standard Thing properties Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Fix sender identifier error with special character Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Add encoding parameter For non latin character in SMS Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply review Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Split local and remote modem in two thing-types Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply review Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply review Signed-off-by: Gwendal Roulleau <[email protected]> * [smsmodem] Apply code review (removing unnecessary method) Signed-off-by: Gwendal Roulleau <[email protected]> Signed-off-by: Gwendal Roulleau <[email protected]> Co-authored-by: Gwendal Roulleau <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>

dalgwen requested a review from a team as a code owner February 9, 2022 01:23

jlaur added the new binding If someone has started to work on a binding. For a new binding PR. label Feb 9, 2022

dalgwen force-pushed the smsmodem_binding_initial_contribution branch from 82f91c8 to 73714e7 Compare March 7, 2022 14:44

dalgwen force-pushed the smsmodem_binding_initial_contribution branch from 195acac to 89c5a03 Compare June 20, 2022 22:32

wborn reviewed Jul 10, 2022

View reviewed changes

bundles/org.openhab.binding.smsmodem/pom.xml Outdated Show resolved Hide resolved

fwolter requested changes Jul 10, 2022

View reviewed changes

dalgwen added 10 commits July 12, 2022 00:44

[smsmodem] Initial contribution

2d6b629

This binding connects to a USB serial GSM modem (or a network exposed one, a.k.a ser2net) and allows openHAB to send and receive SMS through it. Signed-off-by: Gwendal Roulleau <[email protected]>

[smsmodem] README fix

1412204

Signed-off-by: Gwendal Roulleau <[email protected]>

[smsmodem] build/spotless fix

6987f78

Signed-off-by: Gwendal Roulleau <[email protected]>

[smsmodem] compliance with 3rd party license

637220b

And long running thread naming convention And treated some code warning Signed-off-by: Gwendal Roulleau <[email protected]>

[smsmodem] i18n

d8793ae

Signed-off-by: Gwendal Roulleau <[email protected]>

[smsmodem] Small fixes

bf457fc

update channel rename action to avoid colision with other binding and a too generic name Signed-off-by: Gwendal Roulleau <[email protected]>

[smsmodem] Use of standard Thing properties

38150a3

Signed-off-by: Gwendal Roulleau <[email protected]>

[smsmodem] Fix sender identifier error with special character

6b6239e

Signed-off-by: Gwendal Roulleau <[email protected]>

[smsmodem] Add encoding parameter

0a9c704

For non latin character in SMS Signed-off-by: Gwendal Roulleau <[email protected]>

[smsmodem] Apply review

30482c7

Signed-off-by: Gwendal Roulleau <[email protected]>

dalgwen force-pushed the smsmodem_binding_initial_contribution branch from 89c5a03 to 30482c7 Compare July 11, 2022 22:52

[smsmodem] Split local and remote modem in two thing-types

279dc21

Signed-off-by: Gwendal Roulleau <[email protected]>

fwolter requested changes Sep 18, 2022

View reviewed changes

dalgwen added 2 commits September 26, 2022 23:06

[smsmodem] Apply review

86d3991

Signed-off-by: Gwendal Roulleau <[email protected]>

[smsmodem] Apply review

6216419

Signed-off-by: Gwendal Roulleau <[email protected]>

fwolter requested changes Nov 20, 2022

View reviewed changes

[smsmodem] Apply code review (removing unnecessary method)

015cd7f

Signed-off-by: Gwendal Roulleau <[email protected]>

dalgwen force-pushed the smsmodem_binding_initial_contribution branch from 8b2414c to 015cd7f Compare November 23, 2022 11:18

fwolter approved these changes Dec 3, 2022

View reviewed changes

fwolter merged commit 56728b6 into openhab:main Dec 3, 2022

fwolter added this to the 3.4 milestone Dec 3, 2022

dalgwen mentioned this pull request Dec 4, 2022

Added logo for smsmodem openhab/openhab-docs#1942

Merged

dalgwen deleted the smsmodem_binding_initial_contribution branch February 6, 2023 23:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[smsmodem] Initial contribution #12250

[smsmodem] Initial contribution #12250

dalgwen commented Feb 9, 2022

Hilbrand commented Feb 9, 2022

dalgwen commented Feb 9, 2022

fwolter commented Jul 10, 2022

dalgwen commented Jul 10, 2022

fwolter left a comment

dalgwen commented Jul 11, 2022

fwolter commented Aug 14, 2022

dalgwen commented Aug 20, 2022

dalgwen commented Aug 22, 2022

fwolter Sep 18, 2022

dalgwen Sep 26, 2022

fwolter Sep 27, 2022

dalgwen Oct 14, 2022

fwolter Nov 20, 2022

dalgwen Nov 23, 2022

fwolter Sep 18, 2022

dalgwen Sep 26, 2022

fwolter Sep 27, 2022

dalgwen Oct 14, 2022

fwolter Nov 20, 2022

dalgwen Nov 23, 2022

fwolter Dec 3, 2022

fwolter Nov 20, 2022

fwolter Nov 20, 2022

fwolter Nov 20, 2022

fwolter Nov 20, 2022

dalgwen Nov 23, 2022

fwolter left a comment

dalgwen commented Dec 4, 2022

lolodomo commented Dec 4, 2022

lolodomo commented Dec 4, 2022

dalgwen commented Dec 4, 2022 •

edited

Loading

lolodomo commented Dec 4, 2022

	shouldRun = true;
	updateStatus(ThingStatus.UNKNOWN);
	shouldRun = true;

[smsmodem] Initial contribution #12250

[smsmodem] Initial contribution #12250

Conversation

dalgwen commented Feb 9, 2022

Hilbrand commented Feb 9, 2022

dalgwen commented Feb 9, 2022

fwolter commented Jul 10, 2022

dalgwen commented Jul 10, 2022

fwolter left a comment

Choose a reason for hiding this comment

dalgwen commented Jul 11, 2022

fwolter commented Aug 14, 2022

dalgwen commented Aug 20, 2022

dalgwen commented Aug 22, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fwolter left a comment

Choose a reason for hiding this comment

dalgwen commented Dec 4, 2022

lolodomo commented Dec 4, 2022

lolodomo commented Dec 4, 2022

dalgwen commented Dec 4, 2022 • edited Loading

lolodomo commented Dec 4, 2022

dalgwen commented Dec 4, 2022 •

edited

Loading