[panasonictv] Initial Contribution #11558

thinkingstone · 2021-11-11T10:16:08Z

I would like to contribute/continue the work done for adding the panasonictv binding from oh1 to oh3.
Therefore I used the existing migrations from #3904, #6179 and #9024.
There is also a discussion in https://community.openhab.org/t/panasonictv-oh3/108124

Issue for this PR #11559

DESCRIPTION

What is the classification of the PR? => new binding, oh1 migration
Did you describe the PRs motivation and goal? => Yes
Did you provide a link to any prior discussion, e.g. an issue or community forum thread? => https://community.openhab.org/t/panasonictv-oh3/108124 and issues/PRs [panasonictv] Add Panasonic Viera TV Binding #3904, openHAB 1 addon compatibility overview with openHAB 3 #6179 and [WIP][panasonictv] Initial contribution #9024
Did you describe new features for the end user? => README.md
Did you describe any noteworthy changes in usage for the end user? => No necessary
Was the documentation updated accordingly, e.g. the add-on README? => Yes
Does your contribution follow the coding guidelines:
https://www.openhab.org/docs/developer/guidelines.html => Yes
Did you check for any (relevant) issues from the static code analysis:
https://www.openhab.org/docs/developer/bindings/#include-the-binding-in-the-build => Yes
Did you sign-off your work:
https://www.openhab.org/docs/developer/contributing.html#sign-your-work => Yes

Signed-off-by: Prakashbabu Sidaraddi <[email protected]> (github: scienty) # Conflicts: # addons/binding/pom.xml # bundles/org.openhab.binding.panasonictv/.classpath # bundles/org.openhab.binding.panasonictv/.project # bundles/org.openhab.binding.panasonictv/.settings/org.eclipse.core.resources.prefs # bundles/org.openhab.binding.panasonictv/.settings/org.eclipse.jdt.core.prefs # bundles/org.openhab.binding.panasonictv/.settings/org.eclipse.m2e.core.prefs # bundles/org.openhab.binding.panasonictv/ESH-INF/binding/binding.xml # bundles/org.openhab.binding.panasonictv/ESH-INF/config/config.xml # bundles/org.openhab.binding.panasonictv/ESH-INF/i18n/panasonic_de.properties # bundles/org.openhab.binding.panasonictv/ESH-INF/thing/channel-types.xml # bundles/org.openhab.binding.panasonictv/ESH-INF/thing/thing-types.xml # bundles/org.openhab.binding.panasonictv/META-INF/MANIFEST.MF # bundles/org.openhab.binding.panasonictv/OSGI-INF/PanasonicTvDiscovery.xml # bundles/org.openhab.binding.panasonictv/OSGI-INF/PanasonicTvHandlerFactory.xml # bundles/org.openhab.binding.panasonictv/README.md # bundles/org.openhab.binding.panasonictv/about.html # bundles/org.openhab.binding.panasonictv/build.properties # bundles/org.openhab.binding.panasonictv/pom.xml # bundles/org.openhab.binding.panasonictv/src/main/java/org/openhab/binding/panasonictv/PanasonicTvBindingConstants.java # bundles/org.openhab.binding.panasonictv/src/main/java/org/openhab/binding/panasonictv/handler/PanasonicTvHandler.java # bundles/org.openhab.binding.panasonictv/src/main/java/org/openhab/binding/panasonictv/internal/PanasonicTvHandlerFactory.java # bundles/org.openhab.binding.panasonictv/src/main/java/org/openhab/binding/panasonictv/internal/config/PanasonicTvConfiguration.java # bundles/org.openhab.binding.panasonictv/src/main/java/org/openhab/binding/panasonictv/internal/discovery/PanasonicTvDiscoveryParticipant.java # bundles/org.openhab.binding.panasonictv/src/main/java/org/openhab/binding/panasonictv/internal/protocol/RemoteControllerException.java # bundles/org.openhab.binding.panasonictv/src/main/java/org/openhab/binding/panasonictv/internal/protocol/UpnpRemoteController.java # bundles/org.openhab.binding.panasonictv/src/main/java/org/openhab/binding/panasonictv/internal/service/DataConverters.java # bundles/org.openhab.binding.panasonictv/src/main/java/org/openhab/binding/panasonictv/internal/service/MediaRendererService.java # bundles/org.openhab.binding.panasonictv/src/main/java/org/openhab/binding/panasonictv/internal/service/PanasonicTvUtils.java # bundles/org.openhab.binding.panasonictv/src/main/java/org/openhab/binding/panasonictv/internal/service/RemoteControllerService.java # bundles/org.openhab.binding.panasonictv/src/main/java/org/openhab/binding/panasonictv/internal/service/ServiceFactory.java # bundles/org.openhab.binding.panasonictv/src/main/java/org/openhab/binding/panasonictv/internal/service/api/EventListener.java # bundles/org.openhab.binding.panasonictv/src/main/java/org/openhab/binding/panasonictv/internal/service/api/PanasonicTvService.java # features/openhab-addons/src/main/feature/feature.xml

Signed-off-by: Jan N. Klug <[email protected]>

fix readme and properties to changed thing configuration Signed-off-by: Michael Binder <[email protected]>

Signed-off-by: Michael Binder <[email protected]>

optimize imports Signed-off-by: Michael Binder <[email protected]>

Flole998 · 2021-11-13T20:35:06Z

As far as I can see you don't have the power state/command in there? Is there a specific reason for that?

thinkingstone · 2021-11-14T08:04:00Z

As far as I can see you don't have the power state/command in there? Is there a specific reason for that?

You need to send "Power" (or exactly "NRC_POWER-ONOFF") to the keycode channel.
Or maybe I didn't understand what you mean.

I didn't find a way to identify if the device is powered on. My tv can be in standby or powered on mode. In standby it can also be reachable by network or not, depending on it's network settings. If it is reachable the thing is considered online, but I can not determine if is powered on.

Flole998 · 2021-11-15T19:26:38Z

I've described how that's done in #4407. Additionally you should only send the power key code then if the command state is != the current state, otherwise sending on would turn the TV off if it's already on.

fwolter

Thanks for your contribution! I reviewed your code and here is my feedback.

There is one checkstyle warning left. You could take a look at target/code-analysis/report.html after building it with mvn clean install.

fwolter · 2022-01-27T18:42:50Z

CODEOWNERS

@@ -228,6 +228,7 @@
 /bundles/org.openhab.binding.oppo/ @mlobstein
 /bundles/org.openhab.binding.orbitbhyve/ @octa22
 /bundles/org.openhab.binding.orvibo/ @tavalin
+/bundles/org.openhab.binding.panasonictv/ @J-N-K


This username shouldn't be the author, but the maintainer of the binding. If you want to maintain this binding in the future, this should be your username.

fwolter · 2022-01-27T18:43:52Z

bundles/org.openhab.binding.panasonictv/README.md

+Panasonic TVs does not support full UPNP standard functionalities
+Volume and Mute status are updated in real time
+Most of the control is provided by sending Key Code to RemoteControl API
+
+Source Name (read only) is updated when a Key Code to change the source is sent to tv, otherwise it is Undefined


Please finish the sentences with a period (.).

fwolter · 2022-01-27T18:44:14Z

bundles/org.openhab.binding.panasonictv/README.md

+| Model         | State   | Notes                                                                                |
+|---------------|---------|--------------------------------------------------------------------------------------|
+| Viera E6      | OK      | Initial contribution is done by this model                                           |
+| TX-40CX680    | OK      | Initial contribution is done by this model                                           |


You could mention the Thing Type UIDs. These are necessary for textual configuration.

fwolter · 2022-01-27T18:45:08Z

bundles/org.openhab.binding.panasonictv/README.md

+## Binding Configuration
+
+The binding does not require any special configuration.


This can be removed, then.

fwolter · 2022-01-27T18:46:47Z

bundles/org.openhab.binding.panasonictv/README.md

+The Panasonic TV Thing requires the UPNP UDN of the RemoteController and MediaRenderer as a configuration value in order for the binding to know how to access it. Panasonic TV publish several UPnP devices and the manufacturer and service names are used to recognize those UPnP devices.
+Additionally, a refresh interval can be configured in milliseconds to specify how often TV resources are polled.


You could add a table with the configuration parameters like in other binding readmes. See for example https://www.openhab.org/addons/bindings/telegram/#thing-configuration

fwolter · 2022-01-27T19:05:21Z

...ctv/src/main/java/org/openhab/binding/panasonictv/internal/service/MediaRendererService.java

+
+        updateResourceState(SERVICE_ID, "SetVolume",
+                Map.of("InstanceID", "0", "Channel", "Master", "DesiredVolume", Integer.toString(newValue)));
+        // updateResourceState(SERVICE_ID, "GetVolume", Map.of("InstanceID", "0", "Channel", "Master"));


Can this be removed? Same for below.

fwolter · 2022-01-27T19:06:04Z

bundles/org.openhab.binding.panasonictv/src/main/resources/OH-INF/binding/binding.xml

+
+	<name>Panasonic TV Binding</name>
+	<description>This is the binding for Panasonic TV. Binding should support all Panasonic Viera TV models</description>
+	<author>Prakashbabu Sidaraddi</author>


The author tag is deprecated and should therefore be removed. See openhab/openhab-core#1844.

This needs to be adapted to the new addon.xml, the PR to adapt the developer docs is not merged yet, so if you need more details, the corresponding issue is here: openhab/openhab-core#2058
But you can also update your branch and look at another binding's addon.xml and adapt it to this initial contribution.

fwolter · 2022-01-27T19:07:18Z

bundles/org.openhab.binding.panasonictv/src/main/resources/OH-INF/thing/channel-types.xml

+	<channel-type id="volume">
+		<item-type>Dimmer</item-type>
+		<label>Volume</label>
+		<description>Volume level of the TV.</description>
+		<category>SoundVolume</category>
+	</channel-type>


There's a predefined system channel you could use. See https://www.openhab.org/docs/developer/bindings/thing-xml.html#system-state-channel-types

fwolter · 2022-01-27T19:07:36Z

bundles/org.openhab.binding.panasonictv/src/main/resources/OH-INF/thing/channel-types.xml

+	<channel-type id="mute">
+		<item-type>Switch</item-type>
+		<label>Mute</label>
+		<description>Mute state of the TV.</description>
+	</channel-type>


Same for mute.

fwolter · 2022-01-27T19:14:06Z

...ictv/src/main/java/org/openhab/binding/panasonictv/internal/PanasonicTvBindingConstants.java

@@ -0,0 +1,44 @@
+/**
+ * Copyright (c) 2010-2021 Contributors to the openHAB project


This needs to be updated to 2022. You can do it automatically by invoking mvn license:format in the root dir of this repo.

thinkingstone · 2022-02-01T15:46:09Z

Thanks for your contribution! I reviewed your code and here is my feedback.

Thanks you very much. I will check your feedback. This may take some time.

jlaur · 2022-12-23T15:47:34Z

bundles/org.openhab.binding.panasonictv/pom.xml

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">


Suggested change

xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

See #11833

wborn · 2022-12-29T10:50:36Z

bundles/org.openhab.binding.panasonictv/pom.xml

+  <parent>
+    <groupId>org.openhab.addons.bundles</groupId>
+    <artifactId>org.openhab.addons.reactor.bundles</artifactId>
+    <version>3.2.0-SNAPSHOT</version>


Suggested change

<version>3.2.0-SNAPSHOT</version>

<version>4.2.0-SNAPSHOT</version>

openhab-bot · 2023-12-17T12:31:10Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/comparison-to-home-assistant/151931/57

lsiepel · 2024-06-21T12:46:54Z

Unfortunately it looks like we cannot bring this PR to the finish line. After two years of inactivity i close this PR. If there is a need to restart, feel free to re-open or start a new PR.

scienty and others added 7 commits November 11, 2021 10:30

convert to maven build and adapt to OH3

49112d7

Signed-off-by: Jan N. Klug <[email protected]>

code improvements

edf5fc2

Signed-off-by: Jan N. Klug <[email protected]>

further work

175cbf3

Signed-off-by: Jan N. Klug <[email protected]>

fix

71aa3be

Signed-off-by: Jan N. Klug <[email protected]>

update to OH 3.2.0-SNAPSHOT

633ee6b

fix readme and properties to changed thing configuration Signed-off-by: Michael Binder <[email protected]>

apply spotless

39995f5

Signed-off-by: Michael Binder <[email protected]>

thinkingstone requested a review from a team as a code owner November 11, 2021 10:16

thinkingstone mentioned this pull request Nov 11, 2021

[panasonictv] Add / Continue Panasonic Viera TV Binding #11559

Open

fix copyright header

0c3a672

optimize imports Signed-off-by: Michael Binder <[email protected]>

thinkingstone force-pushed the panasonictv branch from b3cef7e to 0c3a672 Compare November 11, 2021 11:12

cweitkamp added the enhancement An enhancement or new feature for an existing add-on label Nov 12, 2021

Hilbrand added the oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2 label Nov 14, 2021

wborn added new binding If someone has started to work on a binding. For a new binding PR. and removed enhancement An enhancement or new feature for an existing add-on labels Nov 27, 2021

fwolter changed the title ~~[panasonictv] Add / Continue Panasonic Viera TV Binding~~ [panasonictv] Initial Contribution Jan 27, 2022

fwolter requested changes Jan 27, 2022

View reviewed changes

lolodomo added the awaiting feedback label Apr 5, 2022

lolodomo added the stale As soon as a PR is marked stale, it can be removed 6 months later. label Nov 5, 2022

jlaur reviewed Dec 23, 2022

View reviewed changes

wborn reviewed Dec 29, 2022

View reviewed changes

stale bot removed the stale As soon as a PR is marked stale, it can be removed 6 months later. label Jan 16, 2023

openhab deleted a comment from fwolter Jul 24, 2023

lsiepel added the stale As soon as a PR is marked stale, it can be removed 6 months later. label Mar 10, 2024

lsiepel closed this Jun 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[panasonictv] Initial Contribution #11558

[panasonictv] Initial Contribution #11558

thinkingstone commented Nov 11, 2021 •

edited

Loading

Flole998 commented Nov 13, 2021

thinkingstone commented Nov 14, 2021 •

edited

Loading

Flole998 commented Nov 15, 2021

fwolter left a comment

fwolter Jan 27, 2022

fwolter Jan 27, 2022

fwolter Jan 27, 2022

fwolter Jan 27, 2022

fwolter Jan 27, 2022

fwolter Jan 27, 2022

fwolter Jan 27, 2022

lsiepel Jan 16, 2023

fwolter Jan 27, 2022

fwolter Jan 27, 2022

fwolter Jan 27, 2022

thinkingstone commented Feb 1, 2022

jlaur Dec 23, 2022

wborn Dec 29, 2022 •

edited

Loading

openhab-bot commented Dec 17, 2023

lsiepel commented Jun 21, 2024

		## Binding Configuration

		The binding does not require any special configuration.

		The Panasonic TV Thing requires the UPNP UDN of the RemoteController and MediaRenderer as a configuration value in order for the binding to know how to access it. Panasonic TV publish several UPnP devices and the manufacturer and service names are used to recognize those UPnP devices.
		Additionally, a refresh interval can be configured in milliseconds to specify how often TV resources are polled.

		@@ -0,0 +1,44 @@
		/**
		* Copyright (c) 2010-2021 Contributors to the openHAB project

	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

	<version>3.2.0-SNAPSHOT</version>
	<version>4.2.0-SNAPSHOT</version>

[panasonictv] Initial Contribution #11558

[panasonictv] Initial Contribution #11558

Conversation

thinkingstone commented Nov 11, 2021 • edited Loading

DESCRIPTION

Flole998 commented Nov 13, 2021

thinkingstone commented Nov 14, 2021 • edited Loading

Flole998 commented Nov 15, 2021

fwolter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thinkingstone commented Feb 1, 2022

Choose a reason for hiding this comment

wborn Dec 29, 2022 • edited Loading

Choose a reason for hiding this comment

openhab-bot commented Dec 17, 2023

lsiepel commented Jun 21, 2024

thinkingstone commented Nov 11, 2021 •

edited

Loading

thinkingstone commented Nov 14, 2021 •

edited

Loading

wborn Dec 29, 2022 •

edited

Loading