[benqprojector] Migrate benqprojector binding to OH3 #10341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
wborn
added
new binding
fwolter
requested changes
Jun 5, 2021
...or/src/main/java/org/openhab/binding/benqprojector/internal/BenqProjectorHandlerFactory.java
Outdated
Show resolved
Hide resolved
.../java/org/openhab/binding/benqprojector/internal/connector/BenqProjectorSerialConnector.java
Outdated
Show resolved
Hide resolved
Comment on lines
158
to
170
| while (elapsedTime < timeout) { | ||
| int availableBytes = in.available(); | ||
| if (availableBytes > 0) { | ||
| byte[] tmpData = new byte[availableBytes]; | ||
| int readBytes = in.read(tmpData, 0, availableBytes); | ||
| resp = resp.concat(new String(tmpData, 0, readBytes, StandardCharsets.US_ASCII)); | ||
| if (resp.contains(END)) { | ||
| return resp.replaceAll("[\\r\\n*#>]", BLANK).replace(data, BLANK); | ||
| } | ||
| } else { | ||
| try { | ||
| Thread.sleep(100); | ||
| } catch (InterruptedException e) { |
There was a problem hiding this comment.
Same here. Why not move this code to the super class and reuse it?
There was a problem hiding this comment.
Agreed, I moved these duplicate blocks to a common method.
bundles/org.openhab.binding.benqprojector/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.benqprojector/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
Signed-off-by: Michael Lobstein <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Aug 3, 2021
Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: Luca Calcaterra <[email protected]>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
Signed-off-by: Michael Lobstein <[email protected]>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
Signed-off-by: Michael Lobstein <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: Michael Lobstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new BenQ projector binding for openHAB to replace the 1.x version. The code from this binding is a clone of the epsonprojector binding and incorporates all lessons learned there from migrating it to OH3.
This will replace the 1.x benqprojector binding referenced in #6179