[tacmi] Additional cleanups & improvements from review

Signed-off-by: Christian Niessner <[email protected]>
openhab · Sep 9, 2020 · 92eb6cf · 92eb6cf
1 parent 222858f
commit 92eb6cf
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/bundles/org.openhab.binding.tacmi/NOTICE b/bundles/org.openhab.binding.tacmi/NOTICE
@@ -17,4 +17,4 @@ https://github.com/openhab/openhab-addons
 attoparser
 * License: Apache 2.0
 * Project: https://www.attoparser.org
-* Source:  https://github.com/attoparser/attoparser
+* Source:  https://github.com/attoparser/attoparser
diff --git a/bundles/org.openhab.binding.tacmi/README.md b/bundles/org.openhab.binding.tacmi/README.md
@@ -262,6 +262,3 @@ A Popup with an option field will be shown showing all possible options, like in
 
 Please be also aware that there are field having more 'state' values than options, i.E. a manual output override: It has 'Auto/On', 'Auto/Off', 'Manual/On', 'Manual/Off' as state, but only 'Auto', 'Manual/On' and 'Manual/Off' as updateable option.
 You only set it to 'Auto' and the extension On/Off is added depending on the system's current state.
-
-
-Finally - It would be great to hear from your projects and ideas / solutions!
diff --git a/...ing.tacmi/src/main/java/org/openhab/binding/tacmi/internal/coe/TACmiCoEBridgeHandler.java b/...ing.tacmi/src/main/java/org/openhab/binding/tacmi/internal/coe/TACmiCoEBridgeHandler.java
@@ -156,7 +156,7 @@ private void checkForTimeouts() {
     @Override
     public void initialize() {
         try {
-            final DatagramSocket coeSocket = new DatagramSocket(coePort);
+            final DatagramSocket coeSocket = new DatagramSocket(COE_PORT);
             coeSocket.setBroadcast(true);
             coeSocket.setSoTimeout(330000); // 300 sec is default resent-time; so we wait 330 secs
             this.coeSocket = coeSocket;
@@ -181,7 +181,7 @@ public void initialize() {
     }
 
     public void sendData(final byte[] pkt, final @Nullable InetAddress cmiAddress) throws IOException {
-        final DatagramPacket packet = new DatagramPacket(pkt, pkt.length, cmiAddress, coePort);
+        final DatagramPacket packet = new DatagramPacket(pkt, pkt.length, cmiAddress, COE_PORT);
         @Nullable
         DatagramSocket sock = this.coeSocket;
         if (sock == null) {

diff --git a/...ing.tacmi/src/main/java/org/openhab/binding/tacmi/internal/schema/TACmiSchemaHandler.java b/...ing.tacmi/src/main/java/org/openhab/binding/tacmi/internal/schema/TACmiSchemaHandler.java
@@ -107,7 +107,7 @@ public void initialize() {
             return;
         }
         this.online = false;
-        updateStatus(ThingStatus.UNKOWN);
+        updateStatus(ThingStatus.UNKNOWN);
 
         this.authHeader = "Basic "
                 + B64Code.encode(config.username + ":" + config.password, StandardCharsets.ISO_8859_1);