Properly delete expired sessions.

Also use bulk delete instead of many queries. Resolves opengovfoundation/madison-editor#3
opengovfoundation · Aug 28, 2015 · 51885bb · 51885bb
1 parent eef5656
commit 51885bb
Showing 1 changed file with 5 additions and 12 deletions.
diff --git a/lib/connect-mysql-session.js b/lib/connect-mysql-session.js
@@ -49,18 +49,11 @@ module.exports = function (connect)
             {
                 if (error) return;
 
-                Session.findAll({where: ['last_activity < ?', Math.round(Date.now() / 1000) + defaultExpiration]})
-                .on('success', function (sessions)
-                {
-                    if (sessions.length > 0)
-                    {
-                        //console.log('Destroying ' + sessions.length + ' expired sessions.');
-                        for (var i in sessions)
-                        {
-                            sessions[i].destroy();
-                        }
-                    }
-                })
+                Session.destroy({'last_activity': {'lt': Math.round(Date.now() / 1000) - defaultExpiration}})
+                // .on('success', function (sessions)
+                // {
+                //     console.log('success');
+                // })
                 .on('failure', function (error)
                 {
                     console.log('Failed to fetch expired sessions:');