Skip to content

Conversation

@wilbrdt
Copy link
Contributor

@wilbrdt wilbrdt commented Jul 18, 2025

Proposal

Now that Marsha media files are hosted and delivered via Scaleway, we can safely decommission the unused AWS Lambda functions and remove the CloudFront configurations.
Additionally, the provisioning of related AWS resources can also be cleaned up.

wilbrdt added 2 commits July 18, 2025 15:27
As Cloudfront is not used anymore on project Marsha, removing it totally.
Cloudfront signed URLs have been removed from Marsha project.
Removing it from the tray.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all AWS Lambda functions and CloudFront configurations from the Marsha project as media files are now hosted and delivered via Scaleway instead of AWS.

Key changes:

  • Removed CloudFront configuration variables and credentials from deployment templates
  • Deleted entire AWS Lambda codebase (convert, medialive, mediapackage, elemental-routing, migrate)
  • Removed AWS infrastructure provisioning (VPC, S3 buckets, IAM roles, security groups)
  • Updated code references from CloudFront to generic storage terminology

Reviewed Changes

Copilot reviewed 138 out of 157 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/tray/vars/vault/main.yml.j2 Removed CloudFront credentials template section
src/tray/vars/all/main.yml Removed CloudFront-related configuration variables
src/tray/templates/services/app/* Removed CloudFront private key secrets and volume mounts from Kubernetes templates
src/backend/marsha/settings.py Commented out AWS MediaLive/MediaPackage settings and removed CloudFront configuration
src/backend/marsha/core/utils/cloudfront_utils.py Deleted CloudFront URL signing utility module
src/backend/marsha/core/serializers/* Updated comments from CloudFront to generic storage references
src/backend/marsha/core/tests/* Removed CloudFront-specific tests and updated test URLs to Scaleway
src/aws/* Deleted all AWS infrastructure files (Lambda functions, Terraform configs, IAM roles)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

As everything has been migrated out of AWS, lambdas are not used anymore.
Removing them from the project.
As everything have now been migrated from AWS to Scaleway, removing all
AWS provisioning and configuration.
@kernicPanel kernicPanel removed the request for review from jonathanreveille October 24, 2025 07:07
@kernicPanel kernicPanel marked this pull request as ready for review October 24, 2025 11:18
@kernicPanel kernicPanel merged commit 91647e6 into master Oct 24, 2025
19 of 20 checks passed
@kernicPanel kernicPanel deleted the remove-cloudfront branch October 24, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants