Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧑‍💻 (makefile) add command to run storybook locally #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🧑‍💻 (makefile) add command to run storybook locally #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Versioning](https://semver.org/spec/v2.0.0.html).

### Added

- Add command to run storybook in the Makefile
- Upgrade docker compose to latest version
- Enable CORS Headers
- Add Multilingual
Expand Down
6 changes: 6 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ COMPOSE_EXEC = $(COMPOSE) exec
COMPOSE_EXEC_APP = $(COMPOSE_EXEC) app
COMPOSE_EXEC_NODE = $(COMPOSE_EXEC) node
COMPOSE_RUN_APP = $(COMPOSE_RUN) app
COMPOSE_RUN_NODE = $(COMPOSE_RUN) node
COMPOSE_RUN_CROWDIN = $(COMPOSE_RUN) crowdin crowdin
COMPOSE_TEST_RUN = $(COMPOSE) run --rm -e DJANGO_CONFIGURATION=Test
COMPOSE_TEST_RUN_APP = $(COMPOSE_TEST_RUN) app
Expand Down Expand Up @@ -124,6 +125,11 @@ test-front:
@$(COMPOSE_RUN) -e HOME="/tmp" -w /app/src/frontend node yarn test
.PHONY:test-front

dev-storybook: ## Run the storybook locally
dev-storybook:
@$(COMPOSE_RUN_NODE) bash -c "cd magnify/packages/components && yarn install && yarn storybook"
.PHONY: dev-storybook

lint-front: ## run all front-end "linters"
lint-front: \
lint-front-eslint \
Expand Down