Add San Francisco map

[RickD004]

Description:

Adds San Francisco bay map. 21 nations based on cities and towns of the area. 1.8M land pixels , size of 2000x1700
Elevation data from Opentopography, already credited.
Map frequency of 3, as to mirror New York map.

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 917d542e-5a80-44f2-9451-2ad01b40f86c

📥 Commits

Reviewing files that changed from the base of the PR and between bd1b11a and 8043246.

📒 Files selected for processing (1)

• resources/maps/sanfrancisco/manifest.json

🚧 Files skipped from review as they are similar to previous changes (1)

• resources/maps/sanfrancisco/manifest.json

---

Walkthrough

Adds a new San Francisco map: static manifest and asset data, localization string, map-generator registration, playlist frequency, and a GameMapType entry.

Changes

Cohort / File(s)	Summary
Map Asset Definitions map-generator/assets/maps/sanfrancisco/info.json, resources/maps/sanfrancisco/manifest.json	New static JSON files describing the San Francisco map: map name, dimensions, land tile counts, and multiple nation entries with coordinates and flag "California".
Translation & Localization resources/lang/en.json	Added English label for the San Francisco map ("sanfrancisco": "San Francisco").
Game Type Registration src/core/game/Game.ts	Added SanFrancisco to GameMapType enum and included it in the regional mapCategories array.
Generator & Runtime Integration map-generator/main.go, src/server/MapPlaylist.ts	Registered sanfrancisco in the map-generator registry; added playlist frequency entry for SanFrancisco (3).

Sequence Diagram(s)

sequenceDiagram
participant Assets as Map Assets
participant Generator as MapGenerator
participant Server as MapPlaylist
participant Game as GameCore

Assets->>Generator: add sanfrancisco assets (info.json, manifest.json)
Generator->>Generator: register "sanfrancisco" in maps registry
Generator->>Server: report available maps (includes sanfrancisco)
Server->>Game: playlist selects SanFrancisco (frequency: 3)
Game->>Game: GameMapType includes SanFrancisco

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A foggy grid, a map appears,
Flags and names across small spheres,
Labels, manifest, and code in tune,
San Francisco joins the rune,
Bay lights blink beneath the moon. 🌉

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: adding a new San Francisco map to the project.
Description check	✅ Passed	The description is directly related to the changeset, providing details about the map (21 nations, size, elevation data, frequency), UI updates, and testing completion.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@resources/maps/sanfrancisco/manifest.json`:
- Around line 79-84: The "strength" property in the manifest entry for the Napa
tile is dead data; remove the "strength" key from the manifest object (the entry
with "name": "Napa" and "coordinates": [1122, 18]) so the manifest matches the
schema consumed by TerrainMapLoader and the upstream generator
(map-generator/assets/maps/sanfrancisco/info.json); if you actually need
per-tile strength behavior instead, implement schema/runtime support in
TerrainMapLoader and the generator instead of adding the field only to the
manifest.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0fa92192-b8ce-4ed7-a881-a4fff5b989b1

📥 Commits

Reviewing files that changed from the base of the PR and between 815f1de and c69425e.

⛔ Files ignored due to path filters (4)

• map-generator/assets/maps/sanfrancisco/image.png is excluded by !**/*.png
• resources/maps/sanfrancisco/map.bin is excluded by !**/*.bin
• resources/maps/sanfrancisco/map16x.bin is excluded by !**/*.bin
• resources/maps/sanfrancisco/map4x.bin is excluded by !**/*.bin

📒 Files selected for processing (7)

• map-generator/assets/maps/sanfrancisco/info.json
• map-generator/main.go
• resources/lang/en.json
• resources/maps/sanfrancisco/manifest.json
• resources/maps/sanfrancisco/thumbnail.webp
• src/core/game/Game.ts
• src/server/MapPlaylist.ts

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@resources/maps/sanfrancisco/manifest.json`:
- Around line 79-83: In manifest.json fix the invalid JSON by removing the
trailing comma after the Napa object property list (the entry with "name":
"Napa", "coordinates": [1122, 18], "flag": "California"); update the Napa object
so it ends without a trailing comma and validate the file (e.g., run a JSON
linter) to ensure the manifest parses correctly.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 37ccbdaf-f75f-4c8e-a3e6-cf3a56524b11

📥 Commits

Reviewing files that changed from the base of the PR and between c69425e and bd1b11a.

📒 Files selected for processing (1)

• resources/maps/sanfrancisco/manifest.json

[evanpelle]

thanks!