feat(chat): add stop trading with all chat option#3362
feat(chat): add stop trading with all chat option#3362evanpelle merged 2 commits intoopenfrontio:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdded a new QuickChat warning key Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Is it possible to reference the "player_panel": { Instead? |
AFAIK you can't directly reference in the json another value. It would imply to add a mapping module which is not complex but out of scope. Maybe if we need multiple references like that it would be worth but for now, I think copy paste will do. |
resources/lang/en.json
Outdated
| "cheating": "[P1] is cheating!", | ||
| "stop_trading": "Stop trading with [P1]!" | ||
| "stop_trading": "Stop trading with [P1]!", | ||
| "stop_trading_all": "Please use \"Stop Trading with All\"." |
There was a problem hiding this comment.
maybe instead just:
Please stop trade with all
There was a problem hiding this comment.
Fine by me, updated.
Description:
Adds a quick chat option to ask a player to stop trading with all. I wrote it in double quote to inform this is an option as I think most of the players do not even know about this option.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found: