Skip to content

feat(chat): add stop trading with all chat option#3362

Merged
evanpelle merged 2 commits intoopenfrontio:mainfrom
DeLoWaN:stop-trading-with-all-chat-message
Mar 8, 2026
Merged

feat(chat): add stop trading with all chat option#3362
evanpelle merged 2 commits intoopenfrontio:mainfrom
DeLoWaN:stop-trading-with-all-chat-message

Conversation

@DeLoWaN
Copy link
Contributor

@DeLoWaN DeLoWaN commented Mar 5, 2026

Description:

Adds a quick chat option to ask a player to stop trading with all. I wrote it in double quote to inform this is an option as I think most of the players do not even know about this option.

image

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

.delovan

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8c27c5ae-59dd-46de-8af1-b9c0d83ea419

📥 Commits

Reviewing files that changed from the base of the PR and between 620dd25 and fbc313d.

📒 Files selected for processing (1)
  • resources/lang/en.json

Walkthrough

Added a new QuickChat warning key stop_trading_all (requiresPlayer: false) and its English localization entry "Please stop trading with all!".

Changes

Cohort / File(s) Summary
Configuration
resources/QuickChat.json
Inserted new warning object { "key": "stop_trading_all", "requiresPlayer": false } into the public warnings array immediately after stop_trading.
Localization
resources/lang/en.json
Added common.warnings.stop_trading_all with value "Please stop trading with all!" and adjusted trailing comma on the preceding stop_trading entry.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

A tiny key, a helpful call,
"Please stop trading with all!"
A JSON tweak, a line in place,
Safer chat with gentle grace,
Small change, big calm—done with a dollop of style ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a new quick chat option for stopping trades with all players.
Description check ✅ Passed The description is related to the changeset, explaining the purpose of the new chat option and confirming that translations and tests were added.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Mar 5, 2026
@ryanbarlow97
Copy link
Contributor

Is it possible to reference the

"player_panel": {
"stop_trade_all": "Stop Trading with All",

Instead?

@DeLoWaN
Copy link
Contributor Author

DeLoWaN commented Mar 6, 2026

Is it possible to reference the

"player_panel": { "stop_trade_all": "Stop Trading with All",

Instead?

AFAIK you can't directly reference in the json another value. It would imply to add a mapping module which is not complex but out of scope. Maybe if we need multiple references like that it would be worth but for now, I think copy paste will do.

"cheating": "[P1] is cheating!",
"stop_trading": "Stop trading with [P1]!"
"stop_trading": "Stop trading with [P1]!",
"stop_trading_all": "Please use \"Stop Trading with All\"."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe instead just:

Please stop trade with all

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, updated.

@github-project-automation github-project-automation bot moved this from Triage to Final Review in OpenFront Release Management Mar 8, 2026
@evanpelle evanpelle added this to the v30 milestone Mar 8, 2026
@evanpelle evanpelle merged commit b648b10 into openfrontio:main Mar 8, 2026
8 of 9 checks passed
@github-project-automation github-project-automation bot moved this from Final Review to Complete in OpenFront Release Management Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants