Skip to content

Refactor: Reuse OutlineFilters to fix allocation issue and potential GC overhead in StructureIconsLayer #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Skigim wants to merge 3 commits into
base: main
Choose a base branch
from
+19 −16
Open

Refactor: Reuse OutlineFilters to fix allocation issue and potential GC overhead in StructureIconsLayer #3339

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d436c26
Perf: Reuse OutlineFilters to reduce lategame GC overhead
Skigim Mar 3, 2026
5389677
Merge branch 'main' into perf/reuse-outline-filters
Skigim Mar 6, 2026
3b4caa8
Merge branch 'main' into perf/reuse-outline-filters
Skigim Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 19 additions & 16 deletions src/client/graphics/layers/StructureIconsLayer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,19 @@ export function shouldPreserveGhostAfterBuild(unitType: UnitType): boolean {

extend([a11yPlugin]);

const FILTER_OUTLINE_RED = new OutlineFilter({
thickness: 2,
color: "rgba(255, 0, 0, 1)",
});
const FILTER_OUTLINE_GREEN = new OutlineFilter({
thickness: 2,
color: "rgba(0, 255, 0, 1)",
});
const FILTER_OUTLINE_WHITE = new OutlineFilter({
thickness: 2,
color: "rgb(255, 255, 255)",
});

class StructureRenderInfo {
public isOnScreen: boolean = false;
constructor(
Expand Down Expand Up @@ -334,9 +347,7 @@ export class StructureIconsLayer implements Layer {
canUpgrade: false,
});
this.updateGhostPrice(0, showPrice);
this.ghostUnit.container.filters = [
new OutlineFilter({ thickness: 2, color: "rgba(255, 0, 0, 1)" }),
];
this.ghostUnit.container.filters = [FILTER_OUTLINE_RED];
this.pendingConfirm = null;
return;
}
Expand All @@ -358,19 +369,15 @@ export class StructureIconsLayer implements Layer {
}
if (this.potentialUpgrade) {
this.potentialUpgrade.iconContainer.filters = [
new OutlineFilter({ thickness: 2, color: "rgba(0, 255, 0, 1)" }),
];
this.potentialUpgrade.dotContainer.filters = [
new OutlineFilter({ thickness: 2, color: "rgba(0, 255, 0, 1)" }),
FILTER_OUTLINE_GREEN,
];
this.potentialUpgrade.dotContainer.filters = [FILTER_OUTLINE_GREEN];
}
// No overlapping when a structure is upgradable
this.uiState.overlappingRailroads = [];
this.uiState.ghostRailPaths = [];
} else if (unit.canBuild === false) {
this.ghostUnit.container.filters = [
new OutlineFilter({ thickness: 2, color: "rgba(255, 0, 0, 1)" }),
];
this.ghostUnit.container.filters = [FILTER_OUTLINE_RED];
this.uiState.overlappingRailroads = [];
this.uiState.ghostRailPaths = [];
} else {
Expand Down Expand Up @@ -684,12 +691,8 @@ export class StructureIconsLayer implements Layer {
render.iconContainer.alpha = structureInfos.visible ? 1 : 0.3;
render.dotContainer.alpha = structureInfos.visible ? 1 : 0.3;
if (structureInfos.visible && this.hasHiddenStructure) {
render.iconContainer.filters = [
new OutlineFilter({ thickness: 2, color: "rgb(255, 255, 255)" }),
];
render.dotContainer.filters = [
new OutlineFilter({ thickness: 2, color: "rgb(255, 255, 255)" }),
];
render.iconContainer.filters = [FILTER_OUTLINE_WHITE];
render.dotContainer.filters = [FILTER_OUTLINE_WHITE];
} else {
render.iconContainer.filters = [];
render.dotContainer.filters = [];
Expand Down
Loading