Update links #67
Merged
Update links #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The more links I checked, the more I found were broken. I got tired of this and adopted an existing script that runs through links and checks them, which itself found some more broken links. I'm not pushing to run that script in automation in this repo, but I'm tracking it in the source tree for future developers that run into this headache. $ pytest tests/test_links.py -r fE
================================================= test session starts ==================================================
platform darwin -- Python 3.11.9, pytest-8.2.0, pluggy-1.5.0
Using --randomly-seed=773047424
rootdir: /Users/mattthompson/software/standards
plugins: randomly-3.15.0, xdist-3.6.1
collected 77 items
tests/test_links.py ...s....s....ss........s.........................s..............s...s.......s [100%]
============================================ 68 passed, 9 skipped in 22.52s ============================================ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterbranch and renamed repoNone of these are substantive changes to the SMIRNOFF specifications so I'm not waiting for review