Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merge after EP 0010] Housekeeping #62

Merged
merged 1 commit into from
Apr 3, 2024
Merged

[Merge after EP 0010] Housekeeping #62

merged 1 commit into from
Apr 3, 2024

Conversation

j-wags
Copy link
Member

@j-wags j-wags commented Feb 22, 2024

I noticed that we haven't updated the navigation bar and table of contents with EPs 8 and 9. To not muddle the conversation around EP 10, I've staged housekeeping updates for EP 8, 9, and 10 in this PR. This should be merged after EP 0010 is merged.

Copy link
Contributor

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattwthompson
Copy link
Member

Doesn't need to be here, but worth considering a checklist in .github/templates/PULL_REQUEST_TEMPLATE.md or whatever the path is. I completely forgot to add these when I authored some of those EPs and I don't think the web UI reminded me

@lilyminium
Copy link
Contributor

This should now be good to merge!

@j-wags j-wags merged commit 5377492 into main Apr 3, 2024
1 check passed
@j-wags j-wags deleted the 2024_02_housekeeping branch April 3, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants